Bug 1298233 - [firefox-ui-tests] Skip TestAppInfo.test_valid_properties for artifact builds. r=ato
authorHenrik Skupin <mail@hskupin.info>
Tue, 27 Nov 2018 20:08:18 +0000
changeset 507593 f2de4c97890147585a46ba5fad12cdf5244a54b1
parent 507592 2d25f33db080c14c8058a8e10c394a9139a9ea42
child 507594 2320933cb7bc8255b7e484df1ef27718154362d5
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersato
bugs1298233
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1298233 - [firefox-ui-tests] Skip TestAppInfo.test_valid_properties for artifact builds. r=ato Differential Revision: https://phabricator.services.mozilla.com/D13093
testing/firefox-ui/tests/puppeteer/manifest.ini
testing/firefox-ui/tests/puppeteer/test_appinfo.py
--- a/testing/firefox-ui/tests/puppeteer/manifest.ini
+++ b/testing/firefox-ui/tests/puppeteer/manifest.ini
@@ -1,13 +1,14 @@
 [DEFAULT]
 tags = local
 
 # API tests
 [test_appinfo.py]
+skip-if = artifact # bug 1298233 - build ids are different for artifact builds
 [test_l10n.py]
 [test_places.py]
 [test_security.py]
 tags = remote
 [test_software_update.py]
 [test_utils.py]
 
 # UI tests
--- a/testing/firefox-ui/tests/puppeteer/test_appinfo.py
+++ b/testing/firefox-ui/tests/puppeteer/test_appinfo.py
@@ -13,19 +13,17 @@ class TestAppInfo(PuppeteerMixin, Marion
     def test_valid_properties(self):
         binary = self.marionette.bin
         version_info = mozversion.get_version(binary=binary)
 
         self.assertEqual(self.puppeteer.appinfo.ID, version_info['application_id'])
         self.assertEqual(self.puppeteer.appinfo.name, version_info['application_name'])
         self.assertEqual(self.puppeteer.appinfo.vendor, version_info['application_vendor'])
         self.assertEqual(self.puppeteer.appinfo.version, version_info['application_version'])
-        # Bug 1298328 - Platform buildid mismatch due to incremental builds
-        # self.assertEqual(self.puppeteer.appinfo.platformBuildID,
-        #                  version_info['platform_buildid'])
+        self.assertEqual(self.puppeteer.appinfo.platformBuildID, version_info['platform_buildid'])
         self.assertEqual(self.puppeteer.appinfo.platformVersion, version_info['platform_version'])
         self.assertIsNotNone(self.puppeteer.appinfo.locale)
         self.assertIsNotNone(self.puppeteer.appinfo.user_agent)
         self.assertIsNotNone(self.puppeteer.appinfo.XPCOMABI)
 
     def test_invalid_properties(self):
         with self.assertRaises(AttributeError):
             self.puppeteer.appinfo.unknown