Bug 1507114 - Use a span element instead of an img element for action and twisty icons. r=emilio, a=RyanVM
authorFlorian Quèze <florian@queze.net>
Wed, 14 Nov 2018 14:46:43 +0100
changeset 501378 f1f4ff30a2995da028729fdc453cec6ff255874a
parent 501377 76164912276b772bc0526abb98747479a4600cfe
child 501379 efca407c5be1476d88cd3ff717ce92cfa7bbfb76
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersemilio, RyanVM
bugs1507114
milestone64.0
Bug 1507114 - Use a span element instead of an img element for action and twisty icons. r=emilio, a=RyanVM
toolkit/components/aboutperformance/content/aboutPerformance.js
--- a/toolkit/components/aboutperformance/content/aboutPerformance.js
+++ b/toolkit/components/aboutperformance/content/aboutPerformance.js
@@ -1069,22 +1069,22 @@ var View = {
     this.displayEnergyImpact(elt, energyImpact);
     row.appendChild(elt);
 
     if (tooltip)
       document.l10n.setAttributes(row, "item", tooltip);
 
     elt = document.createElement("td");
     if (type == "tab") {
-      let img = document.createElement("img");
+      let img = document.createElement("span");
       img.className = "action-icon close-icon";
       document.l10n.setAttributes(img, "close-tab");
       elt.appendChild(img);
     } else if (type == "addon") {
-      let img = document.createElement("img");
+      let img = document.createElement("span");
       img.className = "action-icon addon-icon";
       document.l10n.setAttributes(img, "show-addon");
       elt.appendChild(img);
     }
     row.appendChild(elt);
 
     this._fragment.appendChild(row);
     return row;
@@ -1251,17 +1251,17 @@ var Control = {
           this.selectedRow = row;
         }
 
         if (!children.length)
           continue;
 
         // Show the twisty image.
         let elt = row.firstChild;
-        let img = document.createElement("img");
+        let img = document.createElement("span");
         img.className = "twisty";
         let open = openItems.has(id);
         if (open) {
           img.classList.add("open");
           this._openItems.add(id);
         }
 
         // If there's an l10n id on our <td> node, any image we add will be