Bug 1388072 - Drop Marionette fallback prefs from geckodriver. r=automatedtester
authorAndreas Tolfsen <ato@sny.no>
Mon, 07 Aug 2017 16:13:54 +0100
changeset 425458 f17b7789a510c3ec0fb27c81093cad35274ed788
parent 425457 4d6a54bb44d45fb289a51de1a1769d17c7a8486b
child 425459 eb6df0971ede37e0ebfe1113fd03344c9bca3452
push id1567
push userjlorenzo@mozilla.com
push dateThu, 02 Nov 2017 12:36:05 +0000
treeherdermozilla-release@e512c14a0406 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersautomatedtester
bugs1388072, 1344748
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1388072 - Drop Marionette fallback prefs from geckodriver. r=automatedtester The marionette.defaultPrefs.port and marionette.logging preferences were removed in https://bugzil.la/1344748, which shipped in Firefox 54. Because the next version of geckodriver (0.19.0) will only support Firefox 55 and greater, it is safe to remove the fallbacks. MozReview-Commit-ID: 4fhtoRasqyB
testing/geckodriver/src/marionette.rs
--- a/testing/geckodriver/src/marionette.rs
+++ b/testing/geckodriver/src/marionette.rs
@@ -483,23 +483,20 @@ impl MarionetteHandler {
         for &(ref name, ref value) in prefs::DEFAULT.iter() {
             if !custom_profile || !prefs.contains_key(name) {
                 prefs.insert((*name).clone(), (*value).clone());
             }
         }
 
         prefs.insert_slice(&extra_prefs[..]);
 
-        // fallbacks can be removed when Firefox 54 becomes stable
         if let Some(ref level) = self.current_log_level {
             prefs.insert("marionette.log.level", Pref::new(level.to_string()));
-            prefs.insert("marionette.logging", Pref::new(level.to_string()));  // fallback
         };
         prefs.insert("marionette.port", Pref::new(port as i64));
-        prefs.insert("marionette.defaultPrefs.port", Pref::new(port as i64));  // fallback
 
         prefs.write().map_err(|_| WebDriverError::new(ErrorStatus::UnknownError,
                                                       "Unable to write Firefox profile"))
     }
 }
 
 impl WebDriverHandler<GeckoExtensionRoute> for MarionetteHandler {
     fn handle_command(&mut self, _: &Option<Session>,