Bug 1155283 - remove XULAPP_DEFINES from DIST_FILES_FLAGS; r=mshal
authorNathan Froyd <froydnj@mozilla.com>
Thu, 07 May 2015 10:03:16 -0400
changeset 274190 f171cc700c5ddbeef64a5d2baac54033acf1dc45
parent 274189 d00a52f922ed4e5107cba4a48331a009678118ab
child 274191 3efe5f06818d272bfe1ac853523984416500a9a3
push id863
push userraliiev@mozilla.com
push dateMon, 03 Aug 2015 13:22:43 +0000
treeherdermozilla-release@f6321b14228d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmshal
bugs1155283
milestone40.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1155283 - remove XULAPP_DEFINES from DIST_FILES_FLAGS; r=mshal Nothing uses XULAPP_DEFINES anymore, let's just get rid of it. There are plenty more places to add in defines for DIST_FILES if one is so inclined.
config/rules.mk
--- a/config/rules.mk
+++ b/config/rules.mk
@@ -1263,17 +1263,17 @@ ifneq (,$(wildcard $(srcdir)/jar.mn))
 $(error $(srcdir) contains a jar.mn file but this file is not declared in a JAR_MANIFESTS variable in a moz.build file)
 endif
 endif
 
 ifneq ($(DIST_FILES),)
 DIST_FILES_PATH := $(FINAL_TARGET)
 # We preprocess these, but they don't necessarily have preprocessor directives,
 # so tell them preprocessor to not complain about that.
-DIST_FILES_FLAGS := $(XULAPP_DEFINES) --silence-missing-directive-warnings
+DIST_FILES_FLAGS := --silence-missing-directive-warnings
 PP_TARGETS += DIST_FILES
 endif
 
 # When you move this out of the tools tier, please remove the corresponding
 # hacks in recursivemake.py that check if Makefile.in sets the variable.
 ifneq ($(XPI_PKGNAME),)
 tools realchrome::
 ifdef STRIP_XPI