Bug 1515946 - Let scroll anchoring ride the trains on everything except Fennec. r=dholbert
authorRyan Hunt <rhunt@eqrion.net>
Mon, 21 Jan 2019 01:58:34 +0000
changeset 514617 f1694d9e640bd1768178e121a5d6fb73565bd32c
parent 514616 60944b0fca8ffa2371774326101bffc9a1ed6ec5
child 514623 254bd88c107271f3d1c2ca9969acc0ed507f0a8d
child 514654 6357f5d3428de6bc2d91971b6d950d9f7564e701
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1515946
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1515946 - Let scroll anchoring ride the trains on everything except Fennec. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D17086
mobile/android/app/geckoview-prefs.js
modules/libpref/init/StaticPrefList.h
--- a/mobile/android/app/geckoview-prefs.js
+++ b/mobile/android/app/geckoview-prefs.js
@@ -30,10 +30,14 @@ pref("geckoview.logging", "Debug");
 pref("dom.push.enabled", false);
 
 // Unlike Fennec, GeckoView may have WebRender enabled, and with WebRender we're
 // going with containerless scrolling (because there are no layers at all with
 // WR, so why not go containerless). So we set this pref to pick up the value
 // in gfxPrefs.h from whether or not WR is enabled.
 pref("layout.scroll.root-frame-containers", 2);
 
+// Scroll anchoring is disabled in Fennec but not GeckoView because of
+// regressions involving the dynamic toolbar. See bug 1520666 for more details.
+pref("layout.css.scroll-anchoring.enabled", true);
+
 // Inherit locale from the OS, used for multi-locale builds
 pref("intl.locale.requested", "");
--- a/modules/libpref/init/StaticPrefList.h
+++ b/modules/libpref/init/StaticPrefList.h
@@ -878,17 +878,17 @@ VARCACHE_PREF(
 // Are dynamic reflow roots enabled?
 VARCACHE_PREF(
    "layout.dynamic-reflow-roots.enabled",
    layout_dynamic_reflow_roots_enabled,
   bool, true
 )
 
 // Pref to control enabling scroll anchoring.
-#ifdef NIGHTLY_BUILD
+#ifndef ANDROID
 #define PREF_VALUE true
 #else
 #define PREF_VALUE false
 #endif
 VARCACHE_PREF(
   "layout.css.scroll-anchoring.enabled",
    layout_css_scroll_anchoring_enabled,
   bool, PREF_VALUE