Bug 1429904 - Remove mHash which is now unused. It was only used by FrameKey::operator<. r=njn
authorMarkus Stange <mstange@themasta.com>
Tue, 27 Feb 2018 23:06:31 -0500
changeset 461200 f1408af12dfa9ab53f4da597220c32c27331375f
parent 461199 f96a75472e04d4bb37af3b6e5fbfec543eb81c16
child 461201 bad1b732f5f937bdbb2c1d12f7f3f42d8a31aa7c
push id1683
push usersfraser@mozilla.com
push dateThu, 26 Apr 2018 16:43:40 +0000
treeherdermozilla-release@5af6cb21869d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs1429904
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1429904 - Remove mHash which is now unused. It was only used by FrameKey::operator<. r=njn MozReview-Commit-ID: 5Jc6EYmoZfS
tools/profiler/core/ProfileBufferEntry.h
--- a/tools/profiler/core/ProfileBufferEntry.h
+++ b/tools/profiler/core/ProfileBufferEntry.h
@@ -176,41 +176,35 @@ public:
     mozilla::Maybe<unsigned> mLine;
     mozilla::Maybe<unsigned> mCategory;
     mozilla::Maybe<JITAddress> mJITAddress;
     mozilla::Maybe<uint32_t> mJITDepth;
 
     explicit FrameKey(const char* aLocation)
      : mLocation(aLocation)
     {
-      mHash = Hash();
     }
 
     FrameKey(const FrameKey& aToCopy)
      : mLocation(aToCopy.mLocation)
      , mLine(aToCopy.mLine)
      , mCategory(aToCopy.mCategory)
      , mJITAddress(aToCopy.mJITAddress)
      , mJITDepth(aToCopy.mJITDepth)
     {
-      mHash = Hash();
     }
 
     FrameKey(const JITAddress& aJITAddress, uint32_t aJITDepth)
      : mJITAddress(mozilla::Some(aJITAddress))
      , mJITDepth(mozilla::Some(aJITDepth))
     {
-      mHash = Hash();
     }
 
     uint32_t Hash() const;
     bool operator==(const FrameKey& aOther) const;
-
-  private:
-    uint32_t mHash;
   };
 
   struct StackKey {
     mozilla::Maybe<uint32_t> mPrefixStackIndex;
     uint32_t mFrameIndex;
 
     explicit StackKey(uint32_t aFrame)
      : mFrameIndex(aFrame)