Bug 1510366 - gdb-tests.py --write-failures FILE doesn't work (and it's not entirely clear how it ever did). r=sfink
authorJeff Walden <jwalden@mit.edu>
Tue, 20 Nov 2018 09:45:21 -0800
changeset 507650 ef565bd9da88dc5d5e09ae2f181436a50848afea
parent 507649 5634ba04016cfeef11e590311e4df234a5a2f1f8
child 507651 3cd10aba91304af8ea8502ad52d4ec64fddac0b5
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssfink
bugs1510366
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1510366 - gdb-tests.py --write-failures FILE doesn't work (and it's not entirely clear how it ever did). r=sfink
js/src/gdb/run-tests.py
--- a/js/src/gdb/run-tests.py
+++ b/js/src/gdb/run-tests.py
@@ -127,17 +127,17 @@ class Summary(object):
                             out.write(test.name + '\n')
                 except IOError as err:
                     sys.stderr.write("Error writing worklist file '%s': %s"
                                      % (OPTIONS.worklist, err))
                     sys.exit(1)
 
             if OPTIONS.write_failures:
                 try:
-                    with open(OPTIONS.write_failures) as out:
+                    with open(OPTIONS.write_failures, "w") as out:
                         for test in self.failures:
                             test.show(out)
                 except IOError as err:
                     sys.stderr.write("Error writing worklist file '%s': %s"
                                      % (OPTIONS.write_failures, err))
                     sys.exit(1)
 
         if self.timeouts: