Bug 1521170 - The testcases are ExpressionStatements that include MemberExpressions, not just MemberExpressions. r=MattN
☠☠ backed out by ce496fde2edd ☠ ☠
authorJared Wein <jwein@mozilla.com>
Tue, 22 Jan 2019 23:48:28 +0000
changeset 514928 ee28acf1382f6df640735c8d1cb66c3c80367153
parent 514927 9ec304cd5e28666c8d6a45e99d1a396785c72cfd
child 514929 714ae096d76ebff59c487965500410568ac91008
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMattN
bugs1521170
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1521170 - The testcases are ExpressionStatements that include MemberExpressions, not just MemberExpressions. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D17303
tools/lint/eslint/eslint-plugin-mozilla/tests/use-returnValue.js
--- a/tools/lint/eslint/eslint-plugin-mozilla/tests/use-returnValue.js
+++ b/tools/lint/eslint/eslint-plugin-mozilla/tests/use-returnValue.js
@@ -13,27 +13,26 @@ var RuleTester = require("eslint/lib/tes
 const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6 } });
 
 // ------------------------------------------------------------------------------
 // Tests
 // ------------------------------------------------------------------------------
 
 function invalidCode(code, methodName) {
   let message = `{Array/String}.${methodName} doesn't modify the instance in-place`;
-  return {code, errors: [{message, type: "MemberExpression"}]};
+  return {code, errors: [{message, type: "ExpressionStatement"}]};
 }
 
 ruleTester.run("use-returnValue", rule, {
   valid: [
     "a = foo.concat(bar)",
     "b = bar.concat([1,3,4])",
     "c = baz.concat()",
     "d = qux.join(' ')",
     "e = quux.slice(1)",
-    "Int64.join(-0x80000001, 0)",
   ],
   invalid: [
     invalidCode("foo.concat(bar)", "concat"),
     invalidCode("bar.concat([1,3,4])", "concat"),
     invalidCode("baz.concat()", "concat"),
     invalidCode("qux.join(' ')", "join"),
     invalidCode("quux.slice(1)", "slice"),
   ],