Bug 1054965 - initialize the crash reporter correctly in GMP children; reorder the init method so that mac doesn't early-return it away, r=smichaud a=sledru
authorBenjamin Smedberg <benjamin@smedbergs.us>
Fri, 29 Aug 2014 14:25:14 -0500
changeset 217719 ea81956338648e411cf346087d09ad07d1faf830
parent 217718 c85d1d97e2b4846cc5b78133b6f4d01500bc440e
child 217720 9e9d7d4091e1e6c6e30d984732fd597ee1371d5b
push id515
push userraliiev@mozilla.com
push dateMon, 06 Oct 2014 12:51:51 +0000
treeherdermozilla-release@267c7a481bef [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmichaud, sledru
bugs1054965
milestone33.0a2
Bug 1054965 - initialize the crash reporter correctly in GMP children; reorder the init method so that mac doesn't early-return it away, r=smichaud a=sledru
content/media/gmp/GMPChild.cpp
--- a/content/media/gmp/GMPChild.cpp
+++ b/content/media/gmp/GMPChild.cpp
@@ -131,24 +131,25 @@ GMPChild::Init(const std::string& aPlugi
                base::ProcessHandle aParentProcessHandle,
                MessageLoop* aIOLoop,
                IPC::Channel* aChannel)
 {
   if (!Open(aChannel, aParentProcessHandle, aIOLoop)) {
     return false;
   }
 
+#ifdef MOZ_CRASHREPORTER
+  SendPCrashReporterConstructor(CrashReporter::CurrentThreadId());
+#endif
+
 #if defined(XP_MACOSX) && defined(MOZ_GMP_SANDBOX)
   mPluginPath = aPluginPath;
   return true;
 #endif
 
-#ifdef MOZ_CRASHREPORTER
-  SendPCrashReporterConstructor(CrashReporter::CurrentThreadId());
-#endif
 #if defined(XP_WIN)
   mozilla::SandboxTarget::Instance()->StartSandbox();
 #endif
 
   return LoadPluginLibrary(aPluginPath);
 }
 
 bool