Bug 1303499 - Fix broken IPDL tests (r=me, NPOTB)
authorBill McCloskey <billm@mozilla.com>
Fri, 16 Sep 2016 15:27:49 -0700
changeset 357840 ea326f6e7e6c485907fdb4e1739bcb2707f7c1bc
parent 357839 cfcd8c4f3a36b958002010a9c6d461a7769996d5
child 357841 7b707a4dd05637594fe5680c3fed005d501ef078
push id1324
push usermtabara@mozilla.com
push dateMon, 16 Jan 2017 13:07:44 +0000
treeherdermozilla-release@a01c49833940 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme, NPOTB
bugs1303499
milestone51.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1303499 - Fix broken IPDL tests (r=me, NPOTB)
ipc/ipdl/test/cxx/TestEndpointBridgeMain.cpp
ipc/ipdl/test/cxx/TestEndpointOpens.cpp
--- a/ipc/ipdl/test/cxx/TestEndpointBridgeMain.cpp
+++ b/ipc/ipdl/test/cxx/TestEndpointBridgeMain.cpp
@@ -22,17 +22,17 @@ TestEndpointBridgeMainParent::Main()
     fail("sending Start");
   }
 }
 
 bool
 TestEndpointBridgeMainParent::RecvBridged(Endpoint<PTestEndpointBridgeMainSubParent>&& endpoint)
 {
   TestEndpointBridgeMainSubParent* a = new TestEndpointBridgeMainSubParent();
-  if (!endpoint.Bind(a, nullptr)) {
+  if (!endpoint.Bind(a)) {
     fail("Bind failed");
   }
   return true;
 }
 
 void
 TestEndpointBridgeMainParent::ActorDestroy(ActorDestroyReason why)
 {
@@ -185,17 +185,17 @@ TestEndpointBridgeSubChild::RecvPing()
   return true;
 }
 
 bool
 TestEndpointBridgeSubChild::RecvBridged(Endpoint<PTestEndpointBridgeMainSubChild>&& endpoint)
 {
   TestEndpointBridgeMainSubChild* a = new TestEndpointBridgeMainSubChild();
 
-  if (!endpoint.Bind(a, nullptr)) {
+  if (!endpoint.Bind(a)) {
     fail("failed to Bind");
   }
 
   if (!a->SendHello()) {
     fail("sending Hello");
   }
 
   return true;
--- a/ipc/ipdl/test/cxx/TestEndpointOpens.cpp
+++ b/ipc/ipdl/test/cxx/TestEndpointOpens.cpp
@@ -49,17 +49,17 @@ static void
 OpenParent(TestEndpointOpensOpenedParent* aParent,
            Endpoint<PTestEndpointOpensOpenedParent>&& aEndpoint)
 {
   AssertNotMainThread();
 
   // Open the actor on the off-main thread to park it there.
   // Messages will be delivered to this thread's message loop
   // instead of the main thread's.
-  if (!aEndpoint.Bind(aParent, nullptr)) {
+  if (!aEndpoint.Bind(aParent)) {
     fail("binding Parent");
   }
 }
 
 bool
 TestEndpointOpensParent::RecvStartSubprotocol(
   mozilla::ipc::Endpoint<PTestEndpointOpensOpenedParent>&& endpoint)
 {
@@ -151,17 +151,17 @@ static void
 OpenChild(TestEndpointOpensOpenedChild* aChild,
           Endpoint<PTestEndpointOpensOpenedChild>&& endpoint)
 {
   AssertNotMainThread();
 
   // Open the actor on the off-main thread to park it there.
   // Messages will be delivered to this thread's message loop
   // instead of the main thread's.
-  if (!endpoint.Bind(aChild, nullptr)) {
+  if (!endpoint.Bind(aChild)) {
     fail("binding child endpoint");
   }
 
   // Kick off the unit tests
   if (!aChild->SendHello()) {
     fail("sending Hello");
   }
 }