Bug 945425 - Show the menu button on the Metro start page [r=sfoster]
authorMatt Brubeck <mbrubeck@mozilla.com>
Fri, 06 Dec 2013 21:31:57 -0800
changeset 175040 ea05293f8360632faca98e99a022d4f6276083b1
parent 175039 54fb89e91eee5da2737c303f2ac8dddc516cb4c1
child 175041 8deb6f225d0addfd0a4023133f3f0fe18767e1e3
push id445
push userffxbld
push dateMon, 10 Mar 2014 22:05:19 +0000
treeherdermozilla-release@dc38b741b04e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssfoster
bugs945425
milestone28.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 945425 - Show the menu button on the Metro start page [r=sfoster]
browser/metro/base/content/appbar.js
browser/metro/base/content/browser.xul
browser/metro/theme/browser.css
--- a/browser/metro/base/content/appbar.js
+++ b/browser/metro/base/content/appbar.js
@@ -110,20 +110,21 @@ var Appbar = {
         Appbar._updateStarButton();
       });
     }
   },
 
   onMenuButton: function(aEvent) {
       let typesArray = [];
 
-      if (!BrowserUI.isStartTabVisible)
+      if (!BrowserUI.isStartTabVisible) {
         typesArray.push("find-in-page");
-      if (ContextCommands.getPageSource())
-        typesArray.push("view-page-source");
+        if (ContextCommands.getPageSource())
+          typesArray.push("view-page-source");
+      }
       if (ContextCommands.getStoreLink())
         typesArray.push("ms-meta-data");
       if (ConsolePanelView.enabled)
         typesArray.push("open-error-console");
       if (!Services.metro.immersive)
         typesArray.push("open-jsshell");
 
       typesArray.push("view-on-desktop");
--- a/browser/metro/base/content/browser.xul
+++ b/browser/metro/base/content/browser.xul
@@ -260,20 +260,20 @@ Desktop browser's sync prefs.
           </hbox>
 
           <stack id="toolbar-contextual">
             <observes element="bcast_windowState" attribute="*"/>
             <observes element="bcast_urlbarState" attribute="*"/>
             <hbox id="toolbar-context-page" pack="end">
               <circularprogressindicator id="download-progress" class="appbar-primary"
                                      oncommand="MetroDownloadsView.onDownloadButton()"/>
-              <toolbarbutton id="star-button" class="appbar-primary"
+              <toolbarbutton id="star-button" class="appbar-primary hide-on-start"
                              type="checkbox"
                              oncommand="Appbar.onStarButton()"/>
-              <toolbarbutton id="pin-button" class="appbar-primary"
+              <toolbarbutton id="pin-button" class="appbar-primary hide-on-start"
                              type="checkbox"
                              oncommand="Appbar.onPinButton()"/>
               <toolbarbutton id="menu-button" class="appbar-primary"
                              oncommand="Appbar.onMenuButton(event)"/>
             </hbox>
 
             <hbox id="toolbar-context-autocomplete" pack="end">
               <toolbarbutton id="close-button" class="appbar-primary"
--- a/browser/metro/theme/browser.css
+++ b/browser/metro/theme/browser.css
@@ -709,24 +709,25 @@ documenttab[selected] .documenttab-selec
 #urlbar:not([editing])[loading] > #stop-button,
 #urlbar:not([editing]):not([loading]) > #reload-button {
   visibility: visible;
 }
 
 /* Contextual toolbar controls */
 
 #toolbar-context-autocomplete,
+.hide-on-start,
 #toolbar-context-page {
   transition-property: opacity, visibility;
   transition-duration: @forward_transition_length@;
   transition-timing-function: @metro_animation_easing@;
 }
 
 #toolbar-contextual:not([autocomplete]) #toolbar-context-autocomplete,
-#toolbar-contextual[startpage] #toolbar-context-page,
+#toolbar-contextual[startpage] .hide-on-start,
 #toolbar-contextual[autocomplete] #toolbar-context-page {
   opacity: 0;
   visibility: hidden;
   pointer-events: none;
 }
 
 #toolbar[viewstate="snapped"] #toolbar-contextual {
   visibility: collapse;