Bug 1217003 - Tabs tray (List): Use ImageView without background for close button. r=margaret
authorSebastian Kaspari <s.kaspari@gmail.com>
Thu, 22 Oct 2015 12:41:04 +0200
changeset 304325 e96850747f864d83ab1871510194504f9d5a596c
parent 304324 38c141f004293a4f6d8aca5f2d0ef61881e3b9c0
child 304326 b0d8d94d792b3635adc9ab13e972561434be37f5
push id1001
push userraliiev@mozilla.com
push dateMon, 18 Jan 2016 19:06:03 +0000
treeherdermozilla-release@8b89261f3ac4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmargaret
bugs1217003
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1217003 - Tabs tray (List): Use ImageView without background for close button. r=margaret This creates feature parity with the tab view of the grid tabs tray. Previously the ImageButton created an unpleasant effect when the List row was pressed (due to duplicateParentState). Rather than losing the selection state by removing duplicateParentState, this patch will effectively remove the focus state from the close button. This ressembles the behavior of the close button in the grid version of the tabs tray.
mobile/android/base/resources/layout/tabs_list_item_view.xml
--- a/mobile/android/base/resources/layout/tabs_list_item_view.xml
+++ b/mobile/android/base/resources/layout/tabs_list_item_view.xml
@@ -48,19 +48,18 @@
                   android:gravity="center_vertical"
                   android:singleLine="false"
                   android:maxLines="4"
                   android:drawablePadding="6dp"
                   android:duplicateParentState="true"/>
 
     </LinearLayout>
 
-    <ImageButton android:id="@+id/close"
+    <ImageView android:id="@+id/close"
                  style="@style/TabsItemClose"
                  android:layout_width="34dip"
                  android:layout_height="match_parent"
-                 android:background="@drawable/action_bar_button_inverse"
                  android:scaleType="center"
                  android:contentDescription="@string/close_tab"
                  android:src="@drawable/tab_item_close_button"
                  android:duplicateParentState="true"/>
 
 </org.mozilla.gecko.tabs.TabsLayoutItemView>
\ No newline at end of file