Backout 55adba3eb627 bug 902539 for missing review comment.
authorBrandon Benvie <bbenvie@mozilla.com>
Tue, 15 Oct 2013 12:09:38 -0700
changeset 165681 e8f0cc4920c1bf96e07ab9cf423aa61068b5d8e1
parent 165680 bd7f431601f8b456a608b720259c0292effa282e
child 165682 0cce3352d103bec12ef0f9e96a535de189d1538b
push id428
push userbbajaj@mozilla.com
push dateTue, 28 Jan 2014 00:16:25 +0000
treeherdermozilla-release@cd72a7ff3a75 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs902539
milestone27.0a1
backs out55adba3eb6278a27009c79df5d0549473179da70
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backout 55adba3eb627 bug 902539 for missing review comment.
browser/devtools/debugger/test/browser_dbg_variables-view-01.js
browser/devtools/shared/widgets/VariablesView.jsm
--- a/browser/devtools/debugger/test/browser_dbg_variables-view-01.js
+++ b/browser/devtools/debugger/test/browser_dbg_variables-view-01.js
@@ -95,32 +95,25 @@ function test() {
       "The testScope should remember it is collapsed even if it is hidden.");
 
     testScope.visible = true;
     ok(testScope.visible,
       "The testScope should be visible after reshowing.");
     ok(!testScope.expanded,
       "The testScope should remember it is collapsed after it is reshown.");
 
-    EventUtils.sendMouseEvent({ type: "mousedown", button: 1 },
-      testScope.target.querySelector(".title"),
-      aPanel.panelWin);
-
-    ok(!testScope.expanded,
-      "Clicking the testScope title with the right mouse button should't expand it.");
-
     EventUtils.sendMouseEvent({ type: "mousedown" },
       testScope.target.querySelector(".title"),
       aPanel.panelWin);
 
     ok(testScope.expanded,
-      "Clicking the testScope title should expand it.");
+      "Clicking the testScope tilte should expand it.");
 
     EventUtils.sendMouseEvent({ type: "mousedown" },
       testScope.target.querySelector(".title"),
       aPanel.panelWin);
 
     ok(!testScope.expanded,
-      "Clicking again the testScope title should collapse it.");
+      "Clicking again the testScope tilte should collapse it.");
 
     closeDebuggerAndFinish(aPanel);
   });
 }
--- a/browser/devtools/shared/widgets/VariablesView.jsm
+++ b/browser/devtools/shared/widgets/VariablesView.jsm
@@ -1646,18 +1646,17 @@ Scope.prototype = {
   _addEventListeners: function() {
     this._title.addEventListener("mousedown", this._onClick, false);
   },
 
   /**
    * The click listener for this scope's title.
    */
   _onClick: function(e) {
-    if (e.button != 0 ||
-        e.target == this._inputNode ||
+    if (e.target == this._inputNode ||
         e.target == this._editNode ||
         e.target == this._deleteNode) {
       return;
     }
     this.toggle();
     this.focus();
   },
 
@@ -2774,33 +2773,25 @@ Variable.prototype = Heritage.extend(Sco
         return;
     }
   },
 
   /**
    * The click listener for the edit button.
    */
   _onEdit: function(e) {
-    if (e.button != 0) {
-      return;
-    }
-
     e.preventDefault();
     e.stopPropagation();
     this._activateValueInput();
   },
 
   /**
    * The click listener for the delete button.
    */
   _onDelete: function(e) {
-    if ("button" in e && e.button != 0) {
-      return;
-    }
-
     e.preventDefault();
     e.stopPropagation();
 
     if (this.ownerView.delete) {
       if (!this.ownerView.delete(this)) {
         this.hide();
       }
     }