Bug 1562194 - update heading with no content text label audit rule from failure to warning. r=nchevobbe
authorYura Zenevich <yura.zenevich@gmail.com>
Thu, 04 Jul 2019 10:39:55 +0000
changeset 544142 e81baf6e08736d1b5e81d3618d8e064ea9d734e1
parent 544141 f208e9b31132d7593c9737d6ae4e22915aa822c1
child 544143 bd80bd3877207544ef373aa81efaba6566f318e4
push id2131
push userffxbld-merge
push dateMon, 26 Aug 2019 18:30:20 +0000
treeherdermozilla-release@b19ffb3ca153 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnchevobbe
bugs1562194
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1562194 - update heading with no content text label audit rule from failure to warning. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D36762
devtools/server/actors/accessibility/audit/text-label.js
devtools/server/tests/browser/browser_accessibility_text_label_audit.js
--- a/devtools/server/actors/accessibility/audit/text-label.js
+++ b/devtools/server/actors/accessibility/audit/text-label.js
@@ -283,17 +283,17 @@ const documentRule = function(accessible
  */
 const headingRule = function(accessible) {
   const name = getAccessibleName(accessible);
   if (!name) {
     return { score: FAIL, issue: HEADING_NO_NAME };
   }
 
   const content = accessible.DOMNode.textContent && accessible.DOMNode.textContent.trim();
-  return content ? null : { score: FAIL, issue: HEADING_NO_CONTENT };
+  return content ? null : { score: WARNING, issue: HEADING_NO_CONTENT };
 };
 
 /**
  * A text label rule for accessible objects that represent toolbars and must
  * have a non-empty name if there is more than one toolbar present.
  *
  * @returns {null|Object}
  *          Failure audit report if toolbar accessible object is not the only
--- a/devtools/server/tests/browser/browser_accessibility_text_label_audit.js
+++ b/devtools/server/tests/browser/browser_accessibility_text_label_audit.js
@@ -195,29 +195,29 @@ add_task(async function() {
     ["<fieldset> with aria-label", "#fieldset-4",
       { score: WARNING, issue: FORM_FIELDSET_NO_NAME_FROM_LEGEND }],
     ["<fieldset> with aria-labelledby", "#fieldset-5",
       { score: WARNING, issue: FORM_FIELDSET_NO_NAME_FROM_LEGEND }],
     ["Empty <h1>", "#heading-1", { score: FAIL, issue: HEADING_NO_NAME }],
     ["<h1> with inner content", "#heading-2", null],
     ["<h1> with white space inner content", "#heading-3",
       { score: FAIL, issue: HEADING_NO_NAME }],
-    ["<h1> with aria-label", "#heading-4", { score: FAIL, issue: HEADING_NO_CONTENT }],
+    ["<h1> with aria-label", "#heading-4", { score: WARNING, issue: HEADING_NO_CONTENT }],
     ["<h1> with aria-labelledby", "#heading-5",
-      { score: FAIL, issue: HEADING_NO_CONTENT }],
+      { score: WARNING, issue: HEADING_NO_CONTENT }],
     ["<h1> with inner content and aria-label", "#heading-6", null],
     ["<h1> with inner content and aria-labelledby", "#heading-7", null],
     ["Empty aria heading", "#heading-8", { score: FAIL, issue: HEADING_NO_NAME }],
     ["Aria heading with content", "#heading-9", null],
     ["Aria heading with white space inner content", "#heading-10",
       { score: FAIL, issue: HEADING_NO_NAME }],
     ["Aria heading with aria-label", "#heading-11",
-      { score: FAIL, issue: HEADING_NO_CONTENT }],
+      { score: WARNING, issue: HEADING_NO_CONTENT }],
     ["Aria heading with aria-labelledby", "#heading-12",
-      { score: FAIL, issue: HEADING_NO_CONTENT }],
+      { score: WARNING, issue: HEADING_NO_CONTENT }],
     ["Aria heading with inner content and aria-label", "#heading-13", null],
     ["Aria heading with inner content and aria-labelledby", "#heading-14", null],
     ["Image map with no name", "#imagemap-1", { score: FAIL, issue: IMAGE_NO_NAME }],
     ["Image map with aria-label", "#imagemap-2", null],
     ["Image map with aria-labelledby", "#imagemap-3", null],
     ["Image map with alt attribute", "#imagemap-4", null],
     ["Image map with empty alt attribute", "#imagemap-5", null],
     ["Image map with aria-labelledby an element with empty content", "#imagemap-6",