Bug 968182 - Hide the Android menu before reshowing it with a submenu. r=lucasr
authorWes Johnston <wjohnston@mozilla.com>
Tue, 11 Mar 2014 23:01:22 -0700
changeset 191369 e7f97fa8a86b2be9e451f33cb15d558134e16231
parent 191368 34941dd46be6611af8ba6c741afc7294afe65cd9
child 191370 a56837cfc67c11cc582e5109b0027e3f6b504faa
push id474
push userasasaki@mozilla.com
push dateMon, 02 Jun 2014 21:01:02 +0000
treeherdermozilla-release@967f4cf1b31c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslucasr
bugs968182
milestone30.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 968182 - Hide the Android menu before reshowing it with a submenu. r=lucasr
mobile/android/base/GeckoApp.java
--- a/mobile/android/base/GeckoApp.java
+++ b/mobile/android/base/GeckoApp.java
@@ -365,19 +365,19 @@ public abstract class GeckoApp
 
     @Override
     public void openMenu() {
         openOptionsMenu();
     }
 
     @Override
     public void showMenu(View menu) {
-        // Hide the menu only if we are showing the MenuPopup.
-        if (!HardwareUtils.hasMenuButton())
-            closeMenu();
+        // Hide the menu before we reshow it to avoid platform specific bugs like
+        // bug 794581 and bug 968182.
+        closeMenu();
 
         mMenuPanel.removeAllViews();
         mMenuPanel.addView(menu);
 
         openOptionsMenu();
     }
 
     @Override