Bug 1458814: Remove unused AnimationValue::mGecko. r=hiro
☠☠ backed out by 5630f78d35cf ☠ ☠
authorEmilio Cobos Álvarez <emilio@crisal.io>
Thu, 03 May 2018 18:31:54 +0200
changeset 472971 e7f7ea7ab4af8fe7a9ded72d994845915be0af73
parent 472970 9ac18a3eeaa566385ddf34fd04f13d02a71445fe
child 472972 c61d211a9f1d365936d40f50844b5ca389a5c070
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1458814: Remove unused AnimationValue::mGecko. r=hiro MozReview-Commit-ID: I0TJsSQYe5t
--- a/layout/style/StyleAnimationValue.h
+++ b/layout/style/StyleAnimationValue.h
@@ -76,18 +76,17 @@ struct AnimationValue
     return !mServo;
   float GetOpacity() const;
   // Return the transform list as a RefPtr.
   already_AddRefed<const nsCSSValueSharedList> GetTransformList() const;
-  // Return the scale for mGecko or mServo, which are calculated with
-  // reference to aFrame.
+  // Return the scale for mServo, which is calculated with reference to aFrame.
   mozilla::gfx::Size GetScaleValue(const nsIFrame* aFrame) const;
   // Uncompute this AnimationValue and then serialize it.
   void SerializeSpecifiedValue(nsCSSPropertyID aProperty,
                                nsAString& aString) const;
   // Check if |*this| and |aToValue| can be interpolated.
   bool IsInterpolableWith(nsCSSPropertyID aProperty,
@@ -111,26 +110,16 @@ struct AnimationValue
   static AnimationValue Opacity(float aOpacity);
   // Create an AnimationValue from a transform list.
   static AnimationValue Transform(nsCSSValueSharedList& aList);
   static already_AddRefed<nsCSSValue::Array>
   AppendTransformFunction(nsCSSKeyword aTransformFunction,
                           nsCSSValueList**& aListTail);
-  // mGecko and mServo are mutually exclusive: only one or the other should
-  // ever be set.
-  // FIXME: After obsoleting StyleAnimationValue, we should remove mGecko, and
-  // make AnimationValue a wrapper of RawServoAnimationValue to hide these
-  // FFIs.
-  // Ideally we would use conditional compilation based on MOZ_OLD_STYLE in the
-  // Servo code that wants to initialize mGecko, but that seems tricky.  So for
-  // now, just define a dummy member variable that its initialization code will
-  // work on, even when the old style system is compiled out.
-  uintptr_t mGecko;
   RefPtr<RawServoAnimationValue> mServo;
 struct PropertyStyleAnimationValuePair
   nsCSSPropertyID mProperty;
   AnimationValue mValue;