Bug 887889 - Relax Sqlite.jsm restrictions in browser_startup.js r=florian
authorDoug Thayer <dothayer@mozilla.com>
Mon, 26 Mar 2018 10:08:30 -0700
changeset 472025 e7f2bc2cb13cbf63ef78ce215d0c393f2bd3ef87
parent 472024 744a7b9fe0abd1095d0f5ba464161d51a97a33b7
child 472026 7e4a87170569ece8bec68b8163e430ca43937a44
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersflorian
bugs887889
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 887889 - Relax Sqlite.jsm restrictions in browser_startup.js r=florian We've improved the startup IO situation in bug 887889 by not synchronously initializing a connection to the contentprefs db. However, this means we are loading Sqlite.jsm earlier than we were, which isn't ideal and can be avoided. However, this isn't completely trivial so I'd like to move this work to a follow-up. MozReview-Commit-ID: 6Em0rN26Qj3
browser/base/content/test/performance/browser_startup.js
--- a/browser/base/content/test/performance/browser_startup.js
+++ b/browser/base/content/test/performance/browser_startup.js
@@ -69,16 +69,19 @@ const startupPhases = {
       "resource:///modules/BrowserUsageTelemetry.jsm",
       "resource:///modules/ContentCrashHandlers.jsm",
       "resource:///modules/ShellService.jsm",
       "resource://gre/modules/NewTabUtils.jsm",
       "resource://gre/modules/PageThumbs.jsm",
       "resource://gre/modules/PlacesUtils.jsm",
       "resource://gre/modules/Promise.jsm", // imported by devtools during _delayedStartup
       "resource://gre/modules/Preferences.jsm",
+      // Bug 1448944 - This should be in a stricter bucket, but we
+      // load it to check content prefs on the initial about:blank
+      "resource://gre/modules/Sqlite.jsm",
     ]),
     services: new Set([
       "@mozilla.org/browser/search-service;1",
     ])
   }},
 
   // We are at this phase once we are ready to handle user events.
   // Anything loaded at this phase or before gets in the way of the user
@@ -95,17 +98,16 @@ const startupPhases = {
       "resource://gre/modules/BookmarkHTMLUtils.jsm",
       "resource://gre/modules/Bookmarks.jsm",
       "resource://gre/modules/ContextualIdentityService.jsm",
       "resource://gre/modules/CrashSubmit.jsm",
       "resource://gre/modules/FxAccounts.jsm",
       "resource://gre/modules/FxAccountsStorage.jsm",
       "resource://gre/modules/PlacesBackups.jsm",
       "resource://gre/modules/PlacesSyncUtils.jsm",
-      "resource://gre/modules/Sqlite.jsm",
     ]),
     services: new Set([
       "@mozilla.org/browser/annotation-service;1",
       "@mozilla.org/browser/nav-bookmarks-service;1",
     ])
   }},
 
   // Things that are expected to be completely out of the startup path