Bug 1330791 - Enable the no-irregular-whitespace rule for /services and fix the associated errors. r=markh
authorJared Wein <jwein@mozilla.com>
Thu, 12 Jan 2017 17:27:34 -0500
changeset 377604 e7eb16354b019068369f7eb7df22e9f23aae181a
parent 377603 6caa811ef3d70476aa42ce35471d35cad23a0a6d
child 377605 10ffcb6f4a6c2ed9cfe69cb97a5d4b208664433e
push id1419
push userjlund@mozilla.com
push dateMon, 10 Apr 2017 20:44:07 +0000
treeherdermozilla-release@5e6801b73ef6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmarkh
bugs1330791
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1330791 - Enable the no-irregular-whitespace rule for /services and fix the associated errors. r=markh MozReview-Commit-ID: 5rledRlxUl2
services/.eslintrc.js
services/sync/services-sync.js
services/sync/tps/extensions/tps/resource/tps.jsm
--- a/services/.eslintrc.js
+++ b/services/.eslintrc.js
@@ -10,17 +10,16 @@ module.exports = {
        respective line in this file should be removed. */
     "brace-style": "warn",
     "consistent-return": "warn",
     "no-cond-assign": "warn",
     "no-else-return": "warn",
     "no-empty": "warn",
     "no-ex-assign": "warn",
     "no-func-assign": "warn",
-    "no-irregular-whitespace": "warn",
     "no-native-reassign": "warn",
     "no-nested-ternary": "warn",
     "no-octal": "warn",
     "no-redeclare": "warn",
     "no-unreachable": "warn",
     "no-unsafe-finally": "warn",
     "no-unused-vars": "warn",
     "no-useless-call": "warn"
--- a/services/sync/services-sync.js
+++ b/services/sync/services-sync.js
@@ -86,10 +86,10 @@ pref("services.sync.telemetry.maxPayload
 // if we don't end up validating, we won't try again unless this much time has passed.
 pref("services.sync.validation.interval", 86400); // 24 hours in seconds
 
 // We only run validation `services.sync.validation.percentageChance` percent of
 // the time, even if it's been the right amount of time since the last validation,
 // and you meet the maxRecord checks.
 pref("services.sync.validation.percentageChance", 10);
 
-// We won't validate an engine if it has more than this many records on the server.
+// We won't validate an engine if it has more than this many records on the server.
 pref("services.sync.validation.maxRecords", 100);
--- a/services/sync/tps/extensions/tps/resource/tps.jsm
+++ b/services/sync/tps/extensions/tps/resource/tps.jsm
@@ -817,17 +817,17 @@ var TPS = {
       // so we load Ajv manually.
       let ajvFile = this._getFileRelativeToSourceRoot(testFile, "testing/modules/ajv-4.1.1.js");
       let ajvURL = fileProtocolHandler.getURLSpecFromFile(ajvFile);
       let ns = {};
       Cu.import(ajvURL, ns);
       let ajv = new ns.Ajv({ async: "co*" });
       this.pingValidator = ajv.compile(schema);
     } catch (e) {
-      this.DumpError(`Failed to load ping schema and AJV relative to "${testFile}".`, e);
+      this.DumpError(`Failed to load ping schema and AJV relative to "${testFile}".`, e);
     }
   },
 
   /**
    * Runs a single test phase.
    *
    * This is the main entry point for each phase of a test. The TPS command
    * line driver loads this module and calls into the function with the