Bug 1551551 - Fix dependency checking for when to update developer's npm installs. r=ahal
authorMark Banner <standard8@mozilla.com>
Wed, 15 May 2019 14:34:09 +0000
changeset 535837 e7a45a6189d2de0ba53900ca9e480ba0fc3c1d8b
parent 535836 c9834e23330c28ee333fc83dfb8ba1cf1e113688
child 535838 b392953074b0ff89616a630c71245d2816f55d43
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersahal
bugs1551551
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1551551 - Fix dependency checking for when to update developer's npm installs. r=ahal Differential Revision: https://phabricator.services.mozilla.com/D31075
tools/lint/eslint/setup_helper.py
--- a/tools/lint/eslint/setup_helper.py
+++ b/tools/lint/eslint/setup_helper.py
@@ -173,17 +173,19 @@ def call_process(name, cmd, cwd=None, ap
 
     return True
 
 
 def expected_eslint_modules():
     # Read the expected version of ESLint and external modules
     expected_modules_path = os.path.join(get_project_root(), "package.json")
     with open(expected_modules_path, "r") as f:
-        expected_modules = json.load(f)["dependencies"]
+        sections = json.load(f)
+        expected_modules = sections["dependencies"]
+        expected_modules.update(sections["devDependencies"])
 
     # Also read the in-tree ESLint plugin mozilla information, to ensure the
     # dependencies are up to date.
     mozilla_json_path = os.path.join(get_eslint_module_path(),
                                      "eslint-plugin-mozilla", "package.json")
     with open(mozilla_json_path, "r") as f:
         expected_modules.update(json.load(f)["dependencies"])