Bug 1536816 - Remove the TODO comment in UrlbarInput::handleCommand. r=adw a=jcristau
authorOmkar Konaraddi <okonaraddi@mozilla.com>
Tue, 04 Jun 2019 20:54:18 +0000
changeset 536683 e6273336eca1ebbe8e810c04e887f08ada963bf9
parent 536682 078657522e9e0c0db743a772efa0322d1e436057
child 536684 fc39189ea1635cd833da6466ac5047d02d518117
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersadw, jcristau
bugs1536816
milestone68.0
Bug 1536816 - Remove the TODO comment in UrlbarInput::handleCommand. r=adw a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D33694
browser/components/urlbar/UrlbarInput.jsm
--- a/browser/components/urlbar/UrlbarInput.jsm
+++ b/browser/components/urlbar/UrlbarInput.jsm
@@ -311,19 +311,16 @@ class UrlbarInput {
       this[methodName](event);
     } else {
       throw new Error("Unrecognized UrlbarInput event: " + event.type);
     }
   }
 
   /**
    * Handles an event which would cause a url or text to be opened.
-   * TODO Bug 1536816 the name is currently handleCommand which is compatible with
-   * urlbarBindings. However, it is no longer called automatically by autocomplete,
-   * See _on_keydown.
    *
    * @param {Event} event The event triggering the open.
    * @param {string} [openWhere] Where we expect the result to be opened.
    * @param {object} [openParams]
    *   The parameters related to where the result will be opened.
    * @param {object} [triggeringPrincipal]
    *   The principal that the action was triggered from.
    */