Bug 1486690 - Remove moz_x{malloc,free} in jprof. r=jesup
authorNicholas Nethercote <nnethercote@mozilla.com>
Tue, 28 Aug 2018 15:55:45 +1000
changeset 491483 e5734413c06fefcb1247c096af3e9241235d1857
parent 491482 7aa3a17103b6a4b504e448b0908bd60cb1f5705b
child 491484 8afde49af9c1f5a04c3611d6ef6de53ac98f0d8d
push id1815
push userffxbld-merge
push dateMon, 15 Oct 2018 10:40:45 +0000
treeherdermozilla-release@18d4c09e9378 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjesup
bugs1486690
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1486690 - Remove moz_x{malloc,free} in jprof. r=jesup They appear to be unused; jprof builds without them. Also jprof.h is included prior to their definition in contradiction to the comment above them.
tools/jprof/stub/libmalloc.cpp
--- a/tools/jprof/stub/libmalloc.cpp
+++ b/tools/jprof/stub/libmalloc.cpp
@@ -32,27 +32,16 @@
 #include <execinfo.h>
 
 #include "libmalloc.h"
 #include "jprof.h"
 #include <string.h>
 #include <errno.h>
 #include <dlfcn.h>
 
-// Must define before including jprof.h
-void *moz_xmalloc(size_t size)
-{
-    return malloc(size);
-}
-
-void moz_xfree(void *mem)
-{
-    free(mem);
-}
-
 #ifdef NTO
 #include <sys/link.h>
 extern r_debug _r_debug;
 #else
 #include <link.h>
 #endif
 
 #define USE_GLIBC_BACKTRACE 1