author | Julian Descottes <jdescottes@mozilla.com> |
Tue, 28 Aug 2018 13:41:49 +0000 | |
changeset 491315 | e417158d945697ac2fac51f66685ac5ff017f091 |
parent 491314 | 05672d13ef562c31cdac1bfb8889a9c1646ecf77 |
child 491316 | ccf47d95dc9b3b9bd08dec0b0123480cfe4a18ca |
push id | 1815 |
push user | ffxbld-merge |
push date | Mon, 15 Oct 2018 10:40:45 +0000 |
treeherder | mozilla-release@18d4c09e9378 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | daisuke |
bugs | 1482868 |
milestone | 63.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/devtools/client/aboutdebugging-new/aboutdebugging.css +++ b/devtools/client/aboutdebugging-new/aboutdebugging.css @@ -1,22 +1,22 @@ /* This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ @import "chrome://global/skin/in-content/common.css"; @import "resource://devtools/client/aboutdebugging-new/src/components/App.css"; @import "resource://devtools/client/aboutdebugging-new/src/components/ConnectPage.css"; @import "resource://devtools/client/aboutdebugging-new/src/components/RuntimeInfo.css"; -@import "resource://devtools/client/aboutdebugging-new/src/components/Sidebar.css"; -@import "resource://devtools/client/aboutdebugging-new/src/components/SidebarItem.css"; @import "resource://devtools/client/aboutdebugging-new/src/components/debugtarget/DebugTargetItem.css"; @import "resource://devtools/client/aboutdebugging-new/src/components/debugtarget/DebugTargetList.css"; @import "resource://devtools/client/aboutdebugging-new/src/components/debugtarget/ExtensionDetail.css"; @import "resource://devtools/client/aboutdebugging-new/src/components/debugtarget/WorkerDetail.css"; +@import "resource://devtools/client/aboutdebugging-new/src/components/sidebar/Sidebar.css"; +@import "resource://devtools/client/aboutdebugging-new/src/components/sidebar/SidebarItem.css"; :root { /* Import css variables from common.css */ --text-color: var(--in-content-page-color); } html, body { margin: 0;
--- a/devtools/client/aboutdebugging-new/src/components/App.js +++ b/devtools/client/aboutdebugging-new/src/components/App.js @@ -8,17 +8,17 @@ const { connect } = require("devtools/cl const { createFactory, PureComponent } = require("devtools/client/shared/vendor/react"); const dom = require("devtools/client/shared/vendor/react-dom-factories"); const PropTypes = require("devtools/client/shared/vendor/react-prop-types"); const { PAGES } = require("../constants"); const ConnectPage = createFactory(require("./ConnectPage")); const RuntimePage = createFactory(require("./RuntimePage")); -const Sidebar = createFactory(require("./Sidebar")); +const Sidebar = createFactory(require("./sidebar/Sidebar")); class App extends PureComponent { static get propTypes() { return { // The "dispatch" helper is forwarded to the App component via connect. // From that point, components are responsible for forwarding the dispatch // property to all components who need to dispatch actions. dispatch: PropTypes.func.isRequired,
--- a/devtools/client/aboutdebugging-new/src/components/moz.build +++ b/devtools/client/aboutdebugging-new/src/components/moz.build @@ -1,21 +1,18 @@ # This Source Code Form is subject to the terms of the Mozilla Public # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. DIRS += [ 'debugtarget', + 'sidebar', ] DevToolsModules( 'App.css', 'App.js', 'ConnectPage.css', 'ConnectPage.js', 'RuntimeInfo.css', 'RuntimeInfo.js', 'RuntimePage.js', - 'Sidebar.css', - 'Sidebar.js', - 'SidebarItem.css', - 'SidebarItem.js', )
rename from devtools/client/aboutdebugging-new/src/components/Sidebar.css rename to devtools/client/aboutdebugging-new/src/components/sidebar/Sidebar.css
rename from devtools/client/aboutdebugging-new/src/components/Sidebar.js rename to devtools/client/aboutdebugging-new/src/components/sidebar/Sidebar.js --- a/devtools/client/aboutdebugging-new/src/components/Sidebar.js +++ b/devtools/client/aboutdebugging-new/src/components/sidebar/Sidebar.js @@ -3,17 +3,17 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ "use strict"; const { createFactory, PureComponent } = require("devtools/client/shared/vendor/react"); const dom = require("devtools/client/shared/vendor/react-dom-factories"); const PropTypes = require("devtools/client/shared/vendor/react-prop-types"); -const { PAGES } = require("../constants"); +const { PAGES } = require("../../constants"); const SidebarItem = createFactory(require("./SidebarItem")); const FIREFOX_ICON = "chrome://devtools/skin/images/aboutdebugging-firefox-logo.svg"; const CONNECT_ICON = "chrome://devtools/skin/images/aboutdebugging-connect-icon.svg"; class Sidebar extends PureComponent { static get propTypes() { return {
rename from devtools/client/aboutdebugging-new/src/components/SidebarItem.css rename to devtools/client/aboutdebugging-new/src/components/sidebar/SidebarItem.css
rename from devtools/client/aboutdebugging-new/src/components/SidebarItem.js rename to devtools/client/aboutdebugging-new/src/components/sidebar/SidebarItem.js --- a/devtools/client/aboutdebugging-new/src/components/SidebarItem.js +++ b/devtools/client/aboutdebugging-new/src/components/sidebar/SidebarItem.js @@ -3,17 +3,17 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ "use strict"; const { PureComponent } = require("devtools/client/shared/vendor/react"); const dom = require("devtools/client/shared/vendor/react-dom-factories"); const PropTypes = require("devtools/client/shared/vendor/react-prop-types"); -const Actions = require("../actions/index"); +const Actions = require("../../actions/index"); /** * This component displays an item of the Sidebar component. */ class SidebarItem extends PureComponent { static get propTypes() { return { dispatch: PropTypes.func.isRequired,
new file mode 100644 --- /dev/null +++ b/devtools/client/aboutdebugging-new/src/components/sidebar/moz.build @@ -0,0 +1,10 @@ +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. + +DevToolsModules( + 'Sidebar.css', + 'Sidebar.js', + 'SidebarItem.css', + 'SidebarItem.js', +)