Bug 905850 - Vector should not be copyable (r=terrence)
authorLuke Wagner <luke@mozilla.com>
Fri, 16 Aug 2013 10:21:28 -0500
changeset 156962 e2c977148d7ab6d6f14432f0890cc856e256f280
parent 156961 c7f5065c808cdc4e9b2f3c22fbab5dee494ed703
child 156963 bb025b6949e88dc58b47bd614b49d1e5f20141d3
push id407
push userlsblakk@mozilla.com
push dateTue, 03 Dec 2013 03:32:50 +0000
treeherdermozilla-release@babf8c9ebc52 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersterrence
bugs905850
milestone26.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 905850 - Vector should not be copyable (r=terrence)
mfbt/Vector.h
--- a/mfbt/Vector.h
+++ b/mfbt/Vector.h
@@ -543,18 +543,18 @@ class VectorBase : private AllocPolicy
      * Like sizeOfExcludingThis, but also measures the size of the vector
      * object (which must be heap-allocated) itself.
      */
     size_t sizeOfIncludingThis(MallocSizeOf mallocSizeOf) const;
 
     void swap(ThisVector& other);
 
   private:
-    VectorBase(const ThisVector&) MOZ_DELETE;
-    void operator=(const ThisVector&) MOZ_DELETE;
+    VectorBase(const VectorBase&) MOZ_DELETE;
+    void operator=(const VectorBase&) MOZ_DELETE;
 };
 
 /* This does the re-entrancy check plus several other sanity checks. */
 #define MOZ_REENTRANCY_GUARD_ET_AL \
   ReentrancyGuard g(*this); \
   MOZ_ASSERT_IF(usingInlineStorage(), mCapacity == sInlineCapacity); \
   MOZ_ASSERT(reserved() <= mCapacity); \
   MOZ_ASSERT(mLength <= reserved()); \