Bug 1434662 - Remove dead code. r=gcp
authorFrancois Marier <francois@mozilla.com>
Thu, 19 Apr 2018 16:06:40 -0700
changeset 471363 e1f41b9f1d44fef53b5c717e3bc67dca6bdce845
parent 471362 7bbbf41e92104a15cad390a799d55f89ddc3ae9b
child 471364 c7f6d061d06ca85fcb8e54946cd90ceb93a604d1
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgcp
bugs1434662, 1296820
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1434662 - Remove dead code. r=gcp This check was added in bug 1296820 to disable V4 updates prior to their being implemented. It should have been removed once we landed working support for V4 updates. MozReview-Commit-ID: 828DIS72LNi
toolkit/components/url-classifier/nsUrlClassifierDBService.cpp
--- a/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp
+++ b/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp
@@ -688,21 +688,16 @@ nsUrlClassifierDBServiceWorker::NotifyUp
   // Null out mUpdateObserver before notifying so that BeginUpdate()
   // becomes available prior to callback.
   nsCOMPtr<nsIUrlClassifierUpdateObserver> updateObserver = nullptr;
   updateObserver.swap(mUpdateObserver);
 
   if (NS_SUCCEEDED(mUpdateStatus)) {
     LOG(("Notifying success: %d", mUpdateWaitSec));
     updateObserver->UpdateSuccess(mUpdateWaitSec);
-  } else if (NS_ERROR_NOT_IMPLEMENTED == mUpdateStatus) {
-    LOG(("Treating NS_ERROR_NOT_IMPLEMENTED a successful update "
-         "but still mark it spoiled."));
-    updateObserver->UpdateSuccess(0);
-    mClassifier->ResetTables(Classifier::Clear_Cache, mUpdateTables);
   } else {
     if (LOG_ENABLED()) {
       nsAutoCString errorName;
       mozilla::GetErrorName(mUpdateStatus, errorName);
       LOG(("Notifying error: %s (%" PRIu32 ")", errorName.get(),
            static_cast<uint32_t>(mUpdateStatus)));
     }