Bug 1538253 - VPXDecoder::IsCompatible checks subsampling x members for equality. r=jya a=pascalc
authorBryce Van Dyk <bvandyk@mozilla.com>
Mon, 25 Mar 2019 19:37:39 +0000
changeset 525762 e1be433d057435f00c2126dcbc1a306dbf5c69db
parent 525761 15d5b056cd7d1b3bcf265e1407d2734960931407
child 525763 be897c0f03b58b182c8221eefa1238626dc0e132
push id2032
push userffxbld-merge
push dateMon, 13 May 2019 09:36:57 +0000
treeherdermozilla-release@455c1065dcbe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya, pascalc
bugs1538253
milestone67.0
Bug 1538253 - VPXDecoder::IsCompatible checks subsampling x members for equality. r=jya a=pascalc We had a stray `&&` where a `==` should have been. Differential Revision: https://phabricator.services.mozilla.com/D24526
dom/media/platforms/agnostic/VPXDecoder.h
--- a/dom/media/platforms/agnostic/VPXDecoder.h
+++ b/dom/media/platforms/agnostic/VPXDecoder.h
@@ -103,18 +103,19 @@ class VPXDecoder : public MediaDataDecod
           1             0         YUV 4:2:2
           1             1         YUV 4:2:0
     */
     bool mSubSampling_x = true;
     bool mSubSampling_y = true;
 
     bool IsCompatible(const VPXStreamInfo& aOther) const {
       return mImage == aOther.mImage && mProfile == aOther.mProfile &&
-             mBitDepth == aOther.mBitDepth && mSubSampling_x &&
-             aOther.mSubSampling_x && mSubSampling_y == aOther.mSubSampling_y;
+             mBitDepth == aOther.mBitDepth &&
+             mSubSampling_x == aOther.mSubSampling_x &&
+             mSubSampling_y == aOther.mSubSampling_y;
     }
   };
 
   static bool GetStreamInfo(Span<const uint8_t> aBuffer, VPXStreamInfo& aInfo,
                             Codec aCodec);
 
  private:
   ~VPXDecoder();