Bug 985172 - toggle bookmark label when in overflow panel, r=mak, a=sylvestre
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Wed, 19 Mar 2014 09:51:38 +0000
changeset 192227 e1b07f5a12a1d5e70fec91f36c29790b168d14eb
parent 192226 589c1400785d552eef3beb9d99ce8c1cc3a5afb0
child 192228 43d53eb54223e35d6cd609a34e26c351be56ba79
push id474
push userasasaki@mozilla.com
push dateMon, 02 Jun 2014 21:01:02 +0000
treeherdermozilla-release@967f4cf1b31c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmak, sylvestre
bugs985172
milestone30.0a2
Bug 985172 - toggle bookmark label when in overflow panel, r=mak, a=sylvestre
browser/base/content/browser-places.js
--- a/browser/base/content/browser-places.js
+++ b/browser/base/content/browser-places.js
@@ -1298,20 +1298,26 @@ let BookmarkingUI = {
         this.button.removeAttribute("buttontooltiptext");
       }
       return;
     }
 
     if (this._itemIds.length > 0) {
       this.button.setAttribute("starred", "true");
       this.button.setAttribute("buttontooltiptext", this._starredTooltip);
+      if (this.button.getAttribute("overflowedItem") == "true") {
+        this.button.setAttribute("label", this._starButtonOverflowedStarredLabel);
+      }
     }
     else {
       this.button.removeAttribute("starred");
       this.button.setAttribute("buttontooltiptext", this._unstarredTooltip);
+      if (this.button.getAttribute("overflowedItem") == "true") {
+        this.button.setAttribute("label", this._starButtonOverflowedLabel);
+      }
     }
   },
 
   /**
    * forceReset is passed when we're destroyed and the label should go back
    * to the default (Bookmark This Page) for OS X.
    */
   _updateBookmarkPageMenuItem: function BUI__updateBookmarkPageMenuItem(forceReset) {