Bug 1371515. P1 - remove the |IsShutdown()| check from Seek() which is already handled by ShutdownState. r=kaku
authorJW Wang <jwwang@mozilla.com>
Fri, 09 Jun 2017 11:41:20 +0800
changeset 413900 e10c8efbb0fe265a2fe251e92e5f09c497f1bc10
parent 413899 3df6d3c1bebfeeb501e8f1485da21d9170602736
child 413901 a12ce07a8154626a61eb958088e4569116ed23bc
push id1490
push usermtabara@mozilla.com
push dateMon, 31 Jul 2017 14:08:16 +0000
treeherdermozilla-release@70e32e6bf15e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskaku
bugs1371515
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1371515. P1 - remove the |IsShutdown()| check from Seek() which is already handled by ShutdownState. r=kaku MozReview-Commit-ID: 5V7xCGCsh5j
dom/media/MediaDecoderStateMachine.cpp
--- a/dom/media/MediaDecoderStateMachine.cpp
+++ b/dom/media/MediaDecoderStateMachine.cpp
@@ -3214,21 +3214,16 @@ void MediaDecoderStateMachine::BufferedR
   }
 }
 
 RefPtr<MediaDecoder::SeekPromise>
 MediaDecoderStateMachine::Seek(const SeekTarget& aTarget)
 {
   MOZ_ASSERT(OnTaskQueue());
 
-  if (IsShutdown()) {
-    return MediaDecoder::SeekPromise::CreateAndReject(/* aIgnored = */ true,
-                                                      __func__);
-  }
-
   // We need to be able to seek in some way
   if (!mMediaSeekable && !mMediaSeekableOnlyInBufferedRanges) {
     LOGW("Seek() should not be called on a non-seekable media");
     return MediaDecoder::SeekPromise::CreateAndReject(/* aIgnored = */ true,
                                                       __func__);
   }
 
   if (aTarget.IsNextFrame() && !HasVideo()) {