Bug 1554976 - Allow network functions needed by Rust mDNS responder; r=tjr
☠☠ backed out by 5b1d527eacfc ☠ ☠
authorDan Minor <dminor@mozilla.com>
Wed, 28 Aug 2019 13:09:50 +0000
changeset 554143 e0fc6a1d4332dc93b9c60851f1d936ec969b9e60
parent 554142 848ac630ed23442b071a8cb20f5f16016174ba38
child 554144 5130264150922f930374c4c6db24592bc618f187
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstjr
bugs1554976
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1554976 - Allow network functions needed by Rust mDNS responder; r=tjr This removes these functions: bind, getaddrinfo, recvfrom, sendto, setsockopt, socket from the check_networking test to allow for their use by the Rust mDNS responder. Differential Revision: https://phabricator.services.mozilla.com/D38488
python/mozbuild/mozbuild/action/check_binary.py
--- a/python/mozbuild/mozbuild/action/check_binary.py
+++ b/python/mozbuild/mozbuild/action/check_binary.py
@@ -249,26 +249,24 @@ def check_mozglue_order(target, binary):
     except Empty:
         raise RuntimeError('Could not parse readelf output?')
 
 
 def check_networking(binary):
     retcode = 0
     networking_functions = set([
         # socketpair is not concerning; it is restricted to AF_UNIX
-        "socket", "connect", "accept", "bind", "listen",
-        "getsockname", "getsockopt", "setsockopt",
-        "recv", "recvfrom",
-        "send", "sendto",
+        "connect", "accept", "listen", "getsockname", "getsockopt",
+        "recv", "send",
         # We would be concerned by recvmsg and sendmsg; but we believe
         # they are okay as documented in 1376621#c23
         "gethostbyname", "gethostbyaddr", "gethostent", "sethostent", "endhostent",
         "gethostent_r", "gethostbyname2", "gethostbyaddr_r", "gethostbyname_r",
         "gethostbyname2_r",
-        "getaddrinfo", "getservent", "getservbyname", "getservbyport", "setservent",
+        "getservent", "getservbyname", "getservbyport", "setservent",
         "getprotoent", "getprotobyname", "getprotobynumber", "setprotoent",
         "endprotoent"])
     bad_occurences_names = set()
 
     try:
         for sym in at_least_one(iter_symbols(binary)):
             if sym['addr'] == 0 and sym['name'] in networking_functions:
                 bad_occurences_names.add(sym['name'])