Bug 1497523 - Link to '#privacy-form-autofill' prefs instead of '#privacy' from autofill. r=jaws
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Tue, 16 Oct 2018 17:47:38 +0000
changeset 499970 e0aa704cdd63d38f2cf4137240d9f7bb5f7a3829
parent 499969 3289b676c65b7338ad244ae43b7de1191d496927
child 499971 d71434f407554db9cf5320fbf8098c2a767f91e4
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1497523
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1497523 - Link to '#privacy-form-autofill' prefs instead of '#privacy' from autofill. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D8599
browser/extensions/formautofill/FormAutofillDoorhanger.jsm
browser/extensions/formautofill/FormAutofillParent.jsm
browser/extensions/formautofill/content/formautofill.xml
--- a/browser/extensions/formautofill/FormAutofillDoorhanger.jsm
+++ b/browser/extensions/formautofill/FormAutofillDoorhanger.jsm
@@ -234,17 +234,17 @@ let FormAutofillDoorhanger = {
    * @param  {string} link
    *         Makes it possible to open and highlight a section in preferences
    */
   _appendPrivacyPanelLink(content, message, link) {
     let chromeDoc = content.ownerDocument;
     let privacyLinkElement = chromeDoc.createXULElement("label");
     privacyLinkElement.className = "text-link";
     privacyLinkElement.setAttribute("useoriginprincipal", true);
-    privacyLinkElement.setAttribute("href", link || "about:preferences#privacy");
+    privacyLinkElement.setAttribute("href", link || "about:preferences#privacy-form-autofill");
     privacyLinkElement.setAttribute("value", message);
     content.appendChild(privacyLinkElement);
   },
 
   /**
    * Append the description section to the popupnotificationcontent.
    * @param  {XULElement} content
    *         popupnotificationcontent
--- a/browser/extensions/formautofill/FormAutofillParent.jsm
+++ b/browser/extensions/formautofill/FormAutofillParent.jsm
@@ -242,17 +242,17 @@ FormAutofillParent.prototype = {
         break;
       }
       case "FormAutofill:OnFormSubmit": {
         await this._onFormSubmit(data, target);
         break;
       }
       case "FormAutofill:OpenPreferences": {
         const win = BrowserWindowTracker.getTopWindow();
-        win.openPreferences("panePrivacy", {origin: "autofillFooter"});
+        win.openPreferences("privacy-form-autofill", {origin: "autofillFooter"});
         break;
       }
       case "FormAutofill:GetDecryptedString": {
         let {cipherText, reauth} = data;
         let string;
         try {
           string = await MasterPassword.decrypt(cipherText, reauth);
         } catch (e) {
--- a/browser/extensions/formautofill/content/formautofill.xml
+++ b/browser/extensions/formautofill/content/formautofill.xml
@@ -154,17 +154,17 @@
     </xbl:content>
 
     <handlers>
       <handler event="click" button="0"><![CDATA[
         if (this._warningTextBox.contains(event.originalTarget)) {
           return;
         }
 
-        window.openPreferences("panePrivacy", {origin: "autofillFooter"});
+        window.openPreferences("privacy-form-autofill", {origin: "autofillFooter"});
       ]]></handler>
     </handlers>
 
     <implementation implements="nsIDOMXULSelectControlItemElement">
       <constructor>
         <![CDATA[
           this._itemBox = document.getAnonymousElementByAttribute(
             this, "anonid", "autofill-footer"