Bug 1204577: remove invalid CSS properties from Loop/ Hello source files. r=Standard8
authorMike de Boer <mdeboer@mozilla.com>
Fri, 18 Sep 2015 13:20:59 +0200
changeset 297567 e085c5011da190d492336b759c07f1e6e2acaab9
parent 297566 0ea13f8b1e7752f519ddfe54bdc6f11ad1a2b920
child 297568 c3c54e021517e6ff01947e3e1bd9a57c8d888f05
push id962
push userjlund@mozilla.com
push dateFri, 04 Dec 2015 23:28:54 +0000
treeherdermozilla-release@23a2d286e80f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersStandard8
bugs1204577
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1204577: remove invalid CSS properties from Loop/ Hello source files. r=Standard8
browser/base/content/test/general/browser_parsable_css.js
browser/components/loop/content/css/panel.css
browser/components/loop/content/shared/css/conversation.css
--- a/browser/base/content/test/general/browser_parsable_css.js
+++ b/browser/base/content/test/general/browser_parsable_css.js
@@ -17,23 +17,18 @@ const kWhitelist = [
    errorMessage: /Unknown pseudo-class.*(fullscreen|selection)/i},
   // Tracked in bug 1004428.
   {sourceName: /aboutaccounts\/(main|normalize)\.css/i},
   // TokBox SDK assets, see bug 1032469.
   {sourceName: /loop\/.*sdk-content\/.*\.css$/i},
   // Loop standalone client CSS uses placeholder cross browser pseudo-element
   {sourceName: /loop\/.*\.css/i,
    errorMessage: /Unknown pseudo-class.*placeholder/i},
-  // Loop issues that crept in since this test was broken, see bug ...
-  {sourceName: /loop\/.*shared\/css\/conversation.css/i,
-   errorMessage: /Error in parsing value for 'display'/i},
   {sourceName: /loop\/.*shared\/css\/common.css/i,
    errorMessage: /Unknown property 'user-select'/i},
-  {sourceName: /loop\/.*css\/panel.css/i,
-   errorMessage: /Expected color but found 'none'/i},
   // Highlighter CSS uses chrome-only pseudo-class, see bug 985597.
   {sourceName: /highlighter\.css/i,
    errorMessage: /Unknown pseudo-class.*moz-native-anonymous/i},
 ];
 
 var moduleLocation = gTestPath.replace(/\/[^\/]*$/i, "/parsingTestHelpers.jsm");
 var {generateURIsFromDirTree} = Cu.import(moduleLocation, {});
 
--- a/browser/components/loop/content/css/panel.css
+++ b/browser/components/loop/content/css/panel.css
@@ -1063,17 +1063,16 @@ html[dir="rtl"] .settings-menu .dropdown
   flex-flow: column nowrap;
   background: #fbfbfb;
 }
 
 .fte-get-started-button {
   border: none;
   color: #fff;
   background-color: #00a9dc;
-  border-color: none;
   line-height: 43px;
   margin: 0 15px;
   padding: 0;
   border-radius: 4px;
   font-size: 1.4rem;
   font-weight: bold;
 }
 
--- a/browser/components/loop/content/shared/css/conversation.css
+++ b/browser/components/loop/content/shared/css/conversation.css
@@ -1381,17 +1381,16 @@ html[dir="rtl"] .room-context-btn-close 
   }
 
   .media-wrapper > .focus-stream > .local ~ .conversation-toolbar {
     max-width: calc(75% - 22px);
   }
 
   .media-wrapper > .focus-stream > .local {
     position: absolute;
-    display:fixed;
     right: 0;
     left: auto;
     /* 30% is the height of the text chat. As we have a margin,
        we don't need to worry about any offset for a border */
     bottom: 0;
     margin: 3px;
     object-fit: contain;
     /* These make the avatar look reasonable and the local