Bug 1400979 - Follow-up: Skip test-verify on linux64-ccov; r=gmierz
authorGeoff Brown <gbrown@mozilla.com>
Wed, 20 Sep 2017 18:13:59 -0600
changeset 433989 e024769dac36e22935f1e64a328bb15334d6bdef
parent 433988 545dfc344b3608bceae2d021f47af3fd8ec2bcb3
child 433990 ed32591c239402478f5ff2858e55faf065087728
push id1567
push userjlorenzo@mozilla.com
push dateThu, 02 Nov 2017 12:36:05 +0000
treeherdermozilla-release@e512c14a0406 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgmierz
bugs1400979
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1400979 - Follow-up: Skip test-verify on linux64-ccov; r=gmierz The previous patch was ineffective, because the noted transform over-wrote the yml configuration.
taskcluster/ci/test/tests.yml
taskcluster/taskgraph/transforms/tests.py
--- a/taskcluster/ci/test/tests.yml
+++ b/taskcluster/ci/test/tests.yml
@@ -1994,17 +1994,18 @@ test-verify:
     description: "Extra verification of tests modified on this push"
     suite: test-verification
     treeherder-symbol: tc(TV)
     loopback-video: true
     max-run-time: 5400
     allow-software-gl-layers: false
     run-on-projects:
         by-test-platform:
-            linux64-ccov/.*: [] # don't run on ccov
+            # do not run on ccov; see also the enable_code_coverage transform
+            linux64-ccov/.*: []
             default: built-projects
     tier: 3
     mozharness:
         script: desktop_unittest.py
         no-read-buildbot-config: true
         config:
             by-test-platform:
                 windows.*:
--- a/taskcluster/taskgraph/transforms/tests.py
+++ b/taskcluster/taskgraph/transforms/tests.py
@@ -619,17 +619,18 @@ def handle_keyed_by(config, tests):
                              project=config.params['project'])
         yield test
 
 
 @transforms.add
 def enable_code_coverage(config, tests):
     """Enable code coverage for the linux64-ccov/opt & linux64-jsdcov/opt build-platforms"""
     for test in tests:
-        if test['build-platform'] == 'linux64-ccov/opt':
+        if test['build-platform'] == 'linux64-ccov/opt' and \
+                not test['test-name'].startswith('test-verify'):
             test['mozharness'].setdefault('extra-options', []).append('--code-coverage')
             test['when'] = {}
             test['instance-size'] = 'xlarge'
             test['run-on-projects'] = ['mozilla-central']
 
             if test['test-name'].startswith('talos'):
                 test['max-run-time'] = 7200
                 test['docker-image'] = {"in-tree": "desktop1604-test"}