Bug 1451727 - [marionette] Add "WebDriver:AcceptAlert" in favor of "WebDriver:AcceptDialog". r=ato a=test-only
authorHenrik Skupin <mail@hskupin.info>
Thu, 05 Apr 2018 15:50:28 +0200
changeset 463168 def0f8799e4f663e3062beef4d877000bfdd0f34
parent 463167 7d6400c2038cf35259e42d30541654a94e7a7b9a
child 463169 1bcba4cdfa8611951396c98250aaa31a947f332e
push id1683
push usersfraser@mozilla.com
push dateThu, 26 Apr 2018 16:43:40 +0000
treeherdermozilla-release@5af6cb21869d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersato, test-only
bugs1451727
milestone60.0
Bug 1451727 - [marionette] Add "WebDriver:AcceptAlert" in favor of "WebDriver:AcceptDialog". r=ato a=test-only To be consistent with the spec the command should be named "WebDriver:AcceptAlert". MozReview-Commit-ID: HGB9hJPAvcU
testing/marionette/driver.js
--- a/testing/marionette/driver.js
+++ b/testing/marionette/driver.js
@@ -3520,17 +3520,18 @@ GeckoDriver.prototype.commands = {
   "localization:l10n:localizeProperty": GeckoDriver.prototype.localizeProperty,  // deprecated, remove in Firefox 60
 
   // Reftest service
   "reftest:setup": GeckoDriver.prototype.setupReftest,
   "reftest:run": GeckoDriver.prototype.runReftest,
   "reftest:teardown": GeckoDriver.prototype.teardownReftest,
 
   // WebDriver service
-  "WebDriver:AcceptDialog": GeckoDriver.prototype.acceptDialog,
+  "WebDriver:AcceptAlert": GeckoDriver.prototype.acceptDialog,
+  "WebDriver:AcceptDialog": GeckoDriver.prototype.acceptDialog,  // deprecated, remove in Firefox 63
   "WebDriver:AddCookie": GeckoDriver.prototype.addCookie,
   "WebDriver:Back": GeckoDriver.prototype.goBack,
   "WebDriver:CloseChromeWindow": GeckoDriver.prototype.closeChromeWindow,
   "WebDriver:CloseWindow": GeckoDriver.prototype.close,
   "WebDriver:DeleteAllCookies": GeckoDriver.prototype.deleteAllCookies,
   "WebDriver:DeleteCookie": GeckoDriver.prototype.deleteCookie,
   "WebDriver:DeleteSession": GeckoDriver.prototype.deleteSession,
   "WebDriver:DismissAlert": GeckoDriver.prototype.dismissDialog,