Bug 899987 - Remove workarounds for ui.mouse.radius bug [r=jimm]
authorMatt Brubeck <mbrubeck@mozilla.com>
Thu, 01 Aug 2013 15:47:24 -0700
changeset 155230 dec9047bfadad24bc7076a99b591c7c5acca915c
parent 155229 1325799228939bb00e82f6970ee88ad15afbd6c4
child 155231 e71d2789a9942a8c4a177ec7ae1dff6b95c5adb7
push id407
push userlsblakk@mozilla.com
push dateTue, 03 Dec 2013 03:32:50 +0000
treeherdermozilla-release@babf8c9ebc52 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjimm
bugs899987
milestone25.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 899987 - Remove workarounds for ui.mouse.radius bug [r=jimm]
browser/metro/base/content/bindings/appbar.xml
browser/metro/base/content/bindings/flyoutpanel.xml
browser/metro/base/content/browser.xul
--- a/browser/metro/base/content/bindings/appbar.xml
+++ b/browser/metro/base/content/bindings/appbar.xml
@@ -68,15 +68,10 @@
               this.dismiss();
             } else {
               this.show();
             }
           ]]>
         </body>
       </method>
     </implementation>
-
-    <handlers>
-      <!-- Work around for bug 835175 -->
-      <handler event="click">false;</handler>
-    </handlers>
   </binding>
 </bindings>
--- a/browser/metro/base/content/bindings/flyoutpanel.xml
+++ b/browser/metro/base/content/bindings/flyoutpanel.xml
@@ -94,15 +94,10 @@
         </body>
       </method>
 
       <field name="anonScrollBox" readonly="true"><![CDATA[
         // Expose the anyonymous scrollbox so ScrollUtils.getScrollboxFromElement can find it.
         document.getAnonymousElementByAttribute(this, "class", "flyoutpanel-contents");
       ]]></field>
     </implementation>
-
-    <handlers>
-      <!-- Work around for bug 835175 -->
-      <handler event="click">false;</handler>
-    </handlers>
   </binding>
 </bindings>
--- a/browser/metro/base/content/browser.xul
+++ b/browser/metro/base/content/browser.xul
@@ -176,18 +176,17 @@
   </keyset>
 
   <stack id="stack" flex="1">
     <observes element="bcast_urlbarState" attribute="*"/>
     <!-- Page Area -->
     <vbox id="page">
       <vbox id="tray" class="tray-toolbar" observes="bcast_windowState" >
         <!-- Tabs -->
-        <!-- onclick handler to work around bug 837242 -->
-        <hbox id="tabs-container" observes="bcast_windowState" onclick="void(0);">
+        <hbox id="tabs-container" observes="bcast_windowState">
           <box id="tabs" flex="1"
                 observes="bcast_preciseInput"
                 onselect="BrowserUI.selectTabAndDismiss(this);"
                 onclosetab="BrowserUI.closeTab(this);"/>
           <vbox id="tabs-controls">
             <toolbarbutton id="newtab-button" command="cmd_newTab" label="&newtab.label;"/>
           </vbox>
         </hbox>
@@ -238,18 +237,17 @@
 
       <!-- Content viewport -->
       <stack id="content-viewport">
         <deck id="browsers" flex="1" observes="bcast_preciseInput"/>
         <box id="vertical-scroller" class="scroller" orient="vertical" end="0" top="0"/>
         <box id="horizontal-scroller" class="scroller" orient="horizontal" left="0" bottom="0"/>
 
         <!-- Content touch selection overlay -->
-        <!-- onclick addresses dom bug 835175 -->
-        <box onclick="false" class="selection-overlay-hidden" id="content-selection-overlay"/>
+        <box class="selection-overlay-hidden" id="content-selection-overlay"/>
       </stack>
     </vbox>
 
     <html:div id="overlay-back" class="overlay-button"
               observes="cmd_back"></html:div>
     <html:div id="overlay-plus" class="overlay-button"
               observes="cmd_back"></html:div>
 
@@ -733,21 +731,19 @@
             <radio id="prefs-dnt-nopref" label="&doNotTrack.options.noPreference;" value="-1"/>
             <radio id="prefs-dnt-oktrack" label="&doNotTrack.options.trackingOkay;" value="0"/>
           </radiogroup>
         </setting>
       </settings>
     </flyoutpanel>
 
     <!-- Chrome touch selection overlay -->
-    <!-- onclick addresses dom bug 835175 -->
-    <box onclick="false" class="selection-overlay-hidden" id="chrome-selection-overlay"/>
+    <box class="selection-overlay-hidden" id="chrome-selection-overlay"/>
 
     <box onclick="event.stopPropagation();" id="context-container" class="menu-container" hidden="true">
-      <!-- onclick is dom bug 835175 -->
       <vbox id="context-popup" class="menu-popup">
         <richlistbox id="context-commands" bindingType="contextmenu" flex="1">
           <!-- priority="low" items are hidden by default when a context is being displayed
                for two or more media types. (e.g. a linked image) -->
           <!-- content types preceeded by '!' act as exclusion rules, the menu item will not
                be displayed if the content type is present. -->
           <!-- Note the order of richlistitem here is important as it is reflected in the
                menu itself. -->