Bug 1164784 - Eliminate CSS duplication with perf tool record button. r=jsantell, a=sledru
authorTim Nguyen <ntim.bugs@gmail.com>
Thu, 21 May 2015 13:27:00 -0400
changeset 274862 de16e4cd139ad060023e30042e05ec588cb34391
parent 274861 98b12f19c7b3a1ff214bc881dc19c72fff86caf0
child 274863 701cee0f9ec1641c3c78c924e1132057485e7144
push id863
push userraliiev@mozilla.com
push dateMon, 03 Aug 2015 13:22:43 +0000
treeherdermozilla-release@f6321b14228d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjsantell, sledru
bugs1164784
milestone40.0a2
Bug 1164784 - Eliminate CSS duplication with perf tool record button. r=jsantell, a=sledru
browser/devtools/performance/performance.xul
browser/themes/shared/devtools/performance.inc.css
--- a/browser/devtools/performance/performance.xul
+++ b/browser/devtools/performance/performance.xul
@@ -141,17 +141,18 @@
         <hbox id="empty-notice"
               class="notice-container"
               align="center"
               pack="center"
               flex="1">
           <hbox class="devtools-toolbarbutton-group"
                 pack="center">
             <toolbarbutton class="devtools-toolbarbutton record-button"
-                           label="&profilerUI.startRecording;" />
+                           label="&profilerUI.startRecording;"
+                           standalone="true"/>
           </hbox>
         </hbox>
         <vbox id="performance-view-content" flex="1">
           <vbox id="overview-pane">
             <hbox id="markers-overview"/>
             <hbox id="memory-overview"/>
             <hbox id="time-framerate"/>
           </vbox>
@@ -167,17 +168,18 @@
                   class="notice-container"
                   align="center"
                   pack="center"
                   flex="1">
               <vbox>
                 <hbox class="devtools-toolbarbutton-group"
                       pack="center">
                   <toolbarbutton class="devtools-toolbarbutton record-button"
-                                 label="&profilerUI.stopRecording;" />
+                                 label="&profilerUI.stopRecording;"
+                                 standalone="true"/>
                 </hbox>
                 <label class="realtime-disabled-message">
                   Realtime recording data disabled on non-multiprocess Firefox.
                 </label>
                 <label class="realtime-disabled-on-e10s-message">
                   Enable multiprocess Firefox in preferences for rendering recording data in realtime.
                 </label>
                 <label class="buffer-status-message"
--- a/browser/themes/shared/devtools/performance.inc.css
+++ b/browser/themes/shared/devtools/performance.inc.css
@@ -79,36 +79,23 @@
   text-align: center;
 }
 
 .console-profile-command {
   font-family: monospace;
   margin: 3px 2px;
 }
 
-.theme-dark #performance-view toolbarbutton.record-button {
-  background-color: var(--theme-tab-toolbar-background);
-  border: 1px solid var(--theme-sidebar-background);
-}
-
-.theme-light #performance-view toolbarbutton.record-button {
-  background-color: rgba(221, 221, 221, 1);
-  border: 1px solid rgba(204, 204, 204, 1);
+#performance-view .realtime-message {
+  opacity: 0.5;
+  display: block;
 }
 
 #performance-view toolbarbutton.record-button {
-  margin: 5px;
   padding: 5px;
-  cursor: pointer;
-  text-shadow: none;
-}
-
-#performance-view .realtime-message {
-  opacity: 0.5;
-  display: block;
 }
 
 #performance-view toolbarbutton.record-button[checked],
 #performance-view toolbarbutton.record-button[checked] {
   color: var(--theme-selection-color);
   background: var(--theme-selection-background);
 }