Bug 1480457 Don't pass 'false' into a pointer field; pass nullptr r=aklotz
authorTom Ritter <tom@mozilla.com>
Thu, 30 Aug 2018 12:08:27 +0000
changeset 491866 ddcf3daa268ca6ee795480813e91dd8ac3d688d8
parent 491865 0e0d83a0de607d6c30168482f24b02af51bb0e48
child 491867 87c2ed42acf0614941589b6bc2e33a3690e9c063
push id1815
push userffxbld-merge
push dateMon, 15 Oct 2018 10:40:45 +0000
treeherdermozilla-release@18d4c09e9378 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaklotz
bugs1480457
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1480457 Don't pass 'false' into a pointer field; pass nullptr r=aklotz MozReview-Commit-ID: FUA6jMwCV1d Depends on D4571 Differential Revision: https://phabricator.services.mozilla.com/D4572
gfx/thebes/gfxGDIFontList.cpp
--- a/gfx/thebes/gfxGDIFontList.cpp
+++ b/gfx/thebes/gfxGDIFontList.cpp
@@ -302,17 +302,17 @@ GDIFontEntry::TestCharacterMap(uint32_t 
 
         // previous code was using the group style
         gfxFontStyle fakeStyle;
         if (!IsUpright()) {
             fakeStyle.style = FontSlantStyle::Italic();
         }
         fakeStyle.weight = Weight().Min();
 
-        RefPtr<gfxFont> tempFont = FindOrMakeFont(&fakeStyle, false);
+        RefPtr<gfxFont> tempFont = FindOrMakeFont(&fakeStyle, nullptr);
         if (!tempFont || !tempFont->Valid())
             return false;
         gfxGDIFont *font = static_cast<gfxGDIFont*>(tempFont.get());
 
         HDC dc = GetDC((HWND)nullptr);
         SetGraphicsMode(dc, GM_ADVANCED);
         HFONT hfont = font->GetHFONT();
         HFONT oldFont = (HFONT)SelectObject(dc, hfont);