Bug 1470394 - Increase bookmark panel width to provide enough area for text in other localizations. r=mak a=ritu
☠☠ backed out by d96403683b5b ☠ ☠
authorDão Gottwald <dao@mozilla.com>
Thu, 26 Jul 2018 19:17:13 +0300
changeset 480638 db7a4be05d8f51ae46f0f2e5d81b2a7ba97cb17a
parent 480637 7a7bb13a3f1477e00a86d68172d43ff5184afc8b
child 480639 23bc64507f53b0cba44c72f72539716adcf02d68
push id1757
push userffxbld-merge
push dateFri, 24 Aug 2018 17:02:43 +0000
treeherdermozilla-release@736023aebdb1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmak, ritu
bugs1470394
milestone62.0
Bug 1470394 - Increase bookmark panel width to provide enough area for text in other localizations. r=mak a=ritu
browser/base/content/browser.xul
browser/themes/linux/places/editBookmark.css
browser/themes/osx/places/editBookmark.css
browser/themes/shared/places/editBookmarkPanel.inc.css
browser/themes/windows/places/editBookmark.css
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -234,17 +234,18 @@
       <box class="panel-header">
         <label id="editBookmarkPanelTitle"/>
       </box>
       <html:div id="editBookmarkPanelFaviconContainer">
         <html:img id="editBookmarkPanelFavicon"/>
       </html:div>
       <box id="editBookmarkPanelImage"/>
 #include ../../components/places/content/editBookmarkPanel.inc.xul
-      <hbox id="editBookmarkPanelBottomButtons" pack="end">
+      <hbox id="editBookmarkPanelBottomButtons"
+            style="min-width: 30em;">
 #ifndef XP_UNIX
         <button id="editBookmarkPanelDoneButton"
                 class="editBookmarkPanelBottomButton"
                 label="&editBookmark.done.label;"
                 default="true"
                 oncommand="StarUI.panel.hidePopup();"/>
         <button id="editBookmarkPanelRemoveButton"
                 class="editBookmarkPanelBottomButton"
--- a/browser/themes/linux/places/editBookmark.css
+++ b/browser/themes/linux/places/editBookmark.css
@@ -35,20 +35,16 @@
 .expander-up > .button-box {
   -moz-appearance: button-arrow-up;
 }
 
 .expander-down > .button-box {
   -moz-appearance: button-arrow-down;
 }
 
-#editBookmarkPanelContent {
-  min-width: 23em;
-}
-
 #editBMPanel_folderTree {
   margin-top: 2px;
   margin-bottom: 2px;
 }
 
 /* Hide the value column of the tag autocomplete popup
  * leaving only the comment column visible. This is
  * so that only the tag being edited is shown in the
--- a/browser/themes/osx/places/editBookmark.css
+++ b/browser/themes/osx/places/editBookmark.css
@@ -34,20 +34,16 @@
 .expander-up {
   -moz-appearance: -moz-mac-disclosure-button-open;
 }
 
 .expander-down {
   -moz-appearance: -moz-mac-disclosure-button-closed;
 }
 
-#editBookmarkPanelContent {
-  min-width: 23em;
-}
-
 #editBMPanel_folderTree {
   margin: 6px 4px 0 4px;
 }
 
 /* Hide the value column of the tag autocomplete popup
  * leaving only the comment column visible. This is
  * so that only the tag being edited is shown in the
  * popup.
--- a/browser/themes/shared/places/editBookmarkPanel.inc.css
+++ b/browser/themes/shared/places/editBookmarkPanel.inc.css
@@ -45,17 +45,17 @@ html|img#editBookmarkPanelFavicon[src] {
 #editBookmarkPanelBottomButtons {
   display: flex;
 }
 
 .editBookmarkPanelBottomButton {
   flex: 1;
   -moz-appearance: none;
   margin: 0;
-  padding: .8em;
+  padding: .8em 0;
   color: inherit;
   background-color: var(--arrowpanel-dimmed);
   border-top: 1px solid var(--panel-separator-color);
 }
 
 .editBookmarkPanelBottomButton:not(:last-child) {
   border-inline-end: 1px solid var(--panel-separator-color);
 }
--- a/browser/themes/windows/places/editBookmark.css
+++ b/browser/themes/windows/places/editBookmark.css
@@ -40,20 +40,16 @@
 .expander-up {
   list-style-image: url("chrome://global/skin/icons/collapse.png");
 }
 
 .expander-down {
   list-style-image: url("chrome://global/skin/icons/expand.png");
 }
 
-#editBookmarkPanelContent {
-  min-width: 23em;
-}
-
 #editBMPanel_folderTree {
   margin-top: 2px;
   margin-bottom: 2px;
 }
 
 /* Hide the value column of the tag autocomplete popup
  * leaving only the comment column visible. This is
  * so that only the tag being edited is shown in the