Bug 1215696 - Update tests for mp4parse v0.1.1. r=kinetik
authorRalph Giles <giles@mozilla.com>
Fri, 16 Oct 2015 14:07:22 -0700
changeset 303604 db739c4c8f9797a80689b2f658e785af9f007e55
parent 303603 17b2c866b45416c80bd1fb219373db5007b59e3c
child 303605 8c2d6d3299858f8eb38424440eb3e26b31a432e3
push id1001
push userraliiev@mozilla.com
push dateMon, 18 Jan 2016 19:06:03 +0000
treeherdermozilla-release@8b89261f3ac4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskinetik
bugs1215696
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1215696 - Update tests for mp4parse v0.1.1. r=kinetik Now that this is returning the correct number of tracks for the test file we can un-XFAIL.
media/libstagefright/gtest/TestMP4Rust.cpp
--- a/media/libstagefright/gtest/TestMP4Rust.cpp
+++ b/media/libstagefright/gtest/TestMP4Rust.cpp
@@ -40,11 +40,11 @@ TEST(rust, MP4Metadata)
   ASSERT_TRUE(f != nullptr);
 
   size_t len = 4096;
   std::vector<uint8_t> buf(len);
   size_t read = fread(buf.data(), sizeof(decltype(buf)::value_type), buf.size(), f);
   buf.resize(read);
   fclose(f);
 
-  bool rv = read_box_from_buffer(buf.data(), buf.size());
-  EXPECT_EQ(rv, 0); // XFAIL: Should find 2 tracks in the first 4K.
+  int32_t rv = read_box_from_buffer(buf.data(), buf.size());
+  EXPECT_EQ(rv, 2);
 }