Bug 1509381 - Fix debug-mode page-cycles value when page-cycles < 2; r=Bebe
authorRob Wood <rwood@mozilla.com>
Fri, 23 Nov 2018 11:26:18 +0000
changeset 507026 db5baa0f06cadbf73248db73f6fae4bad4d7d9a3
parent 507025 0fa44cb3f4b686913a397c6297c26d5f9c64bcb9
child 507027 736ffbc67da4ead952b76d645ae51207f876d503
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersBebe
bugs1509381
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1509381 - Fix debug-mode page-cycles value when page-cycles < 2; r=Bebe Differential Revision: https://phabricator.services.mozilla.com/D12704
testing/raptor/raptor/manifest.py
--- a/testing/raptor/raptor/manifest.py
+++ b/testing/raptor/raptor/manifest.py
@@ -190,17 +190,17 @@ def get_raptor_test_list(args, oskey):
         if args.debug_mode is True:
             next_test['debug_mode'] = True
             LOG.info("debug-mode enabled")
             max_page_cycles = 2
         if args.page_cycles is not None:
             next_test['page_cycles'] = args.page_cycles
             LOG.info("set page-cycles to %d as specified on cmd line" % args.page_cycles)
         else:
-            if next_test['page_cycles'] > max_page_cycles:
+            if int(next_test['page_cycles']) > max_page_cycles:
                 next_test['page_cycles'] = max_page_cycles
                 LOG.info("page-cycles set to %d" % next_test['page_cycles'])
         # if --page-timeout was provided on the command line, use that instead of INI
         if args.page_timeout is not None:
             LOG.info("setting page-timeout to %d as specified on cmd line" % args.page_timeout)
             next_test['page_timeout'] = args.page_timeout
 
     # write out .json test setting files for the control server to read and send to web ext