Bug 1471415 - Fix logic in nsXULPopupManager::ShouldConsumeOnMouseWheelEvent. r=smaug, a=RyanVM
authorEmilio Cobos Álvarez <emilio@crisal.io>
Thu, 28 Jun 2018 16:52:14 +0000
changeset 473793 dabf33a256d5
parent 473792 c7663317f3d4
child 473794 6b6ded8230f1
push id1737
push userryanvm@gmail.com
push date2018-07-02 16:05 +0000
treeherdermozilla-release@ced0b5dc71eb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug, RyanVM
bugs1471415, 1423990
milestone61.0.1
Bug 1471415 - Fix logic in nsXULPopupManager::ShouldConsumeOnMouseWheelEvent. r=smaug, a=RyanVM It was accidentally toggled in bug 1423990. Differential Revision: https://phabricator.services.mozilla.com/D1863
layout/xul/nsXULPopupManager.cpp
--- a/layout/xul/nsXULPopupManager.cpp
+++ b/layout/xul/nsXULPopupManager.cpp
@@ -382,17 +382,17 @@ bool nsXULPopupManager::ShouldConsumeOnM
   nsMenuChainItem* item = GetTopVisibleMenu();
   if (!item)
     return false;
 
   nsMenuPopupFrame* frame = item->Frame();
   if (frame->PopupType() != ePopupTypePanel)
     return true;
 
-  return frame->GetContent()->AsElement()->AttrValueIs(
+  return !frame->GetContent()->AsElement()->AttrValueIs(
       kNameSpaceID_None, nsGkAtoms::type, nsGkAtoms::arrow, eCaseMatters);
 }
 
 // a menu should not roll up if activated by a mouse activate message (eg. X-mouse)
 bool nsXULPopupManager::ShouldRollupOnMouseActivate()
 {
   return false;
 }