Bug 1457495 [wpt PR 10687] - Use sha:<SHA> in tag_master.py instead of just <SHA>, a=testonly
authorPhilip Jägenstedt <philip@foolip.org>
Tue, 01 May 2018 15:57:24 +0000
changeset 472696 daa2a67d21834d1f4c8b91ebfd4921d8e0781d52
parent 472695 08f956ee12af04ce8df5c8179cb8fada7fa1aca4
child 472697 346413cd49cafc88c2bb5a555ce3c15d9d3f3d41
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1457495, 10687
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1457495 [wpt PR 10687] - Use sha:<SHA> in tag_master.py instead of just <SHA>, a=testonly Automatic update from web-platform-testsUse sha:<SHA> in tag_master.py instead of just <SHA> (#10687) This is to avoid finding PRs where commit SHAs have been mentioned, for example reverts, or just in PR comments. Example of search which had 2 results before and 1 after: https://api.github.com/search/issues?q=type:pr+is:merged+repo:w3c/web-platform-tests+280005efe04503f14891d73c6ceab1077a59a735 https://api.github.com/search/issues?q=type:pr+is:merged+repo:w3c/web-platform-tests+sha:280005efe04503f14891d73c6ceab1077a59a735 Kudos to @lukebjerring for pointing out the problem/solution. -- wpt-commits: b651151c05fb95e24f13b17864624676cfbccbac wpt-pr: 10687
testing/web-platform/tests/tools/ci/tag_master.py
--- a/testing/web-platform/tests/tools/ci/tag_master.py
+++ b/testing/web-platform/tests/tools/ci/tag_master.py
@@ -13,17 +13,17 @@ if not(wpt_root in sys.path):
 
 from tools.wpt.testfiles import get_git_cmd
 
 logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger(__name__)
 
 
 def get_pr(repo, owner, sha):
-    url = ("https://api.github.com/search/issues?q=type:pr+is:merged+repo:%s/%s+%s" %
+    url = ("https://api.github.com/search/issues?q=type:pr+is:merged+repo:%s/%s+sha:%s" %
            (repo, owner, sha))
     try:
         resp = urllib2.urlopen(url)
         body = resp.read()
     except Exception as e:
         logger.error(e)
         return None