Bug 1533720, drop point indicator must be aligned relative to arrowscrollbox, r=Gijs
authorNeil Deakin <neil@mozilla.com>
Mon, 11 Mar 2019 14:14:12 +0000
changeset 524572 d9d93f0c41c025c1e9fee4050401f99081ceb3ca
parent 524571 8b95b04d367d47a9749cda81a0fbf007c75d6797
child 524573 109dd3329637173fca52d796d389e4c4f41f99fe
push id2032
push userffxbld-merge
push dateMon, 13 May 2019 09:36:57 +0000
treeherdermozilla-release@455c1065dcbe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1533720
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1533720, drop point indicator must be aligned relative to arrowscrollbox, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D22755
browser/components/places/content/menu.xml
--- a/browser/components/places/content/menu.xml
+++ b/browser/components/places/content/menu.xml
@@ -433,17 +433,17 @@
         if (dropPoint.folderElt || this._hideDropIndicator(event)) {
           this._indicatorBar.hidden = true;
           event.preventDefault();
           event.stopPropagation();
           return;
         }
 
         // We should display the drop indicator relative to the arrowscrollbox.
-        let scrollRect = this._scrollBox.scrollbox.getBoundingClientRect();
+        let scrollRect = this._scrollBox.getBoundingClientRect();
         let newMarginTop = 0;
         if (scrollDir == 0) {
           let elt = this.firstElementChild;
           while (elt && event.screenY > elt.screenY +
                                         elt.getBoundingClientRect().height / 2)
             elt = elt.nextElementSibling;
           newMarginTop = elt ? elt.screenY - this._scrollBox.screenY :
                                scrollRect.height;