Bug 1442945 - Fix DND in Places menus. r=standard8
authorMarco Bonardo <mbonardo@mozilla.com>
Sun, 04 Mar 2018 12:22:57 +0100
changeset 461558 d97c0342dc0dee82622cb8de573ae1408c6cf36b
parent 461557 b1431462ceaf023d852bf52a7608307a3fd4b33f
child 461559 195a3f9c9d2b3ec4d94c1cd9244d1241c62a224b
push id1683
push usersfraser@mozilla.com
push dateThu, 26 Apr 2018 16:43:40 +0000
treeherdermozilla-release@5af6cb21869d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersstandard8
bugs1442945
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1442945 - Fix DND in Places menus. r=standard8 MozReview-Commit-ID: 1fFYgsWOJMV
browser/components/places/content/menu.xml
--- a/browser/components/places/content/menu.xml
+++ b/browser/components/places/content/menu.xml
@@ -64,17 +64,17 @@
            dragging over this popup insertion point -->
       <method name="_getDropPoint">
         <parameter name="aEvent"/>
           <body><![CDATA[
             // Can't drop if the menu isn't a folder
             let resultNode = this._placesNode;
 
             if (!PlacesUtils.nodeIsFolder(resultNode) ||
-                PlacesControllerDragHelper.disallowInsertion(resultNode, this._rootView)) {
+                this._rootView.controller.disallowInsertion(resultNode)) {
               return null;
             }
 
             var dropPoint = { ip: null, folderElt: null };
 
             // The element we are dragging over
             let elt = aEvent.target;
             if (elt.localName == "menupopup")