Bug 1520310 - Disable SANDBOX_EXPORTS for the mingw-clang build as well r=bobowen
☠☠ backed out by ed02a9881c0d ☠ ☠
authorTom Ritter <tom@mozilla.com>
Mon, 21 Jan 2019 11:42:03 -0600
changeset 514772 d8e4a86e306a43a3675402068da51ed038d19414
parent 514771 19db0edfbc10ad8f540a0a3482bd78c0baf7246d
child 514773 65e0b8a04d1af93fb35ce946565b665767bf07c3
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbobowen
bugs1520310
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1520310 - Disable SANDBOX_EXPORTS for the mingw-clang build as well r=bobowen
security/sandbox/moz.build
--- a/security/sandbox/moz.build
+++ b/security/sandbox/moz.build
@@ -154,17 +154,17 @@ elif CONFIG['OS_ARCH'] == 'WINNT':
         SOURCES += [
             'chromium/sandbox/win/src/resolver_32.cc',
             'chromium/sandbox/win/src/service_resolver_32.cc',
         ]
 
     for var in ('UNICODE', '_UNICODE', 'NS_NO_XPCOM',
                 '_CRT_RAND_S', 'CHROMIUM_SANDBOX_BUILD'):
         DEFINES[var] = True
-    if CONFIG['CC_TYPE'] != 'gcc':
+    if CONFIG['CC_TYPE'] not in ('gcc', 'clang'):
         DEFINES['SANDBOX_EXPORTS'] = True
 
     LOCAL_INCLUDES += ['/security/sandbox/chromium-shim']
     LOCAL_INCLUDES += ['/security/sandbox/chromium']
     LOCAL_INCLUDES += ['/nsprpub']
 
     DisableStlWrapping()