Bug 1451827 - In dark popups styled by webext themes, set --urlbar-popup-url-color and .text-link color to the same value. r=jaws a=RyanVM DEVEDITION_61_0b9_BUILD1 DEVEDITION_61_0b9_RELEASE FENNEC_61_0b9_BUILD1 FENNEC_61_0b9_RELEASE FIREFOX_61_0b9_BUILD1 FIREFOX_61_0b9_RELEASE
authorDão Gottwald <dao@mozilla.com>
Sat, 26 May 2018 18:37:27 +0200
changeset 473482 d81b581fbd2cdb5fcfd982c7d2d3222204192725
parent 473481 fd2dd9452ccd7b0b22656a4566a136a8c1eb27af
child 473483 26aca693aff8c81f07c6f3cb69df5768140e7929
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws, RyanVM
bugs1451827
milestone61.0
Bug 1451827 - In dark popups styled by webext themes, set --urlbar-popup-url-color and .text-link color to the same value. r=jaws a=RyanVM MozReview-Commit-ID: 20dLQ4bIBgu
browser/themes/shared/browser.inc.css
browser/themes/shared/urlbar-autocomplete.inc.css
toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js
--- a/browser/themes/shared/browser.inc.css
+++ b/browser/themes/shared/browser.inc.css
@@ -3,33 +3,34 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 %include downloads/indicator.inc.css
 %include addons/extension-controlled.inc.css
 
 %filter substitution
 %define navbarTabsShadowSize 1px
 %define themeTransition background-color 0.1s cubic-bezier(.17,.67,.83,.67)
+%define lwtPopupBrighttextLinkColor #45a1ff
 
 :root {
   /* Note: Setting this to 0 (without px) breaks CSS calculations for OSX. */
   --space-above-tabbar: 0px;
 }
 
 :root[extradragspace][tabsintitlebar]:not([inFullscreen]) {
   --space-above-tabbar: 8px;
 }
 
 :root[sessionrestored]:-moz-lwtheme {
   transition: @themeTransition@;
 }
 
 /* Increase contrast of UI links on dark themes */
 :root[lwt-popup-brighttext] panel .text-link {
-  color: #45a1ff;
+  color: @lwtPopupBrighttextLinkColor@;
 }
 
 /* Toolbar / content area border */
 
 #navigator-toolbox::after {
   content: "";
   display: -moz-box;
   border-bottom: 1px solid var(--toolbox-border-bottom-color);
--- a/browser/themes/shared/urlbar-autocomplete.inc.css
+++ b/browser/themes/shared/urlbar-autocomplete.inc.css
@@ -13,17 +13,17 @@
 }
 
 :root[lwt-popup-darktext] {
   --urlbar-popup-url-color: hsl(210, 77%, 47%);
   --urlbar-popup-action-color: hsl(178, 100%, 28%);
 }
 
 :root[lwt-popup-brighttext] {
-  --urlbar-popup-url-color: #0a84ff;
+  --urlbar-popup-url-color: @lwtPopupBrighttextLinkColor@;
   --urlbar-popup-action-color: #30e60b;
 }
 
 #PopupAutoCompleteRichResult,
 #PopupSearchAutoComplete {
   background: var(--autocomplete-popup-background);
   color: var(--autocomplete-popup-color);
   border-color: var(--autocomplete-popup-border-color);
--- a/toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js
+++ b/toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js
@@ -6,17 +6,17 @@ const POPUP_COLOR = "#85A400";
 const POPUP_BORDER_COLOR = "#220300";
 const POPUP_TEXT_COLOR_DARK = "#000000";
 const POPUP_TEXT_COLOR_BRIGHT = "#ffffff";
 const POPUP_SELECTED_COLOR = "#9400ff";
 const POPUP_SELECTED_TEXT_COLOR = "#09b9a6";
 
 const POPUP_URL_COLOR_DARK = "#1c78d4";
 const POPUP_ACTION_COLOR_DARK = "#008f8a";
-const POPUP_URL_COLOR_BRIGHT = "#0a84ff";
+const POPUP_URL_COLOR_BRIGHT = "#45a1ff";
 const POPUP_ACTION_COLOR_BRIGHT = "#30e60b";
 
 const SEARCH_TERM = "urlbar-reflows-" + Date.now();
 const ONEOFF_URLBAR_PREF = "browser.urlbar.oneOffSearches";
 
 XPCOMUtils.defineLazyModuleGetters(this, {
   PlacesTestUtils: "resource://testing-common/PlacesTestUtils.jsm",
 });