Bug 1355010: temporarily turn off extmap direction verification to avoid Chrome interop issues. r=bwc
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Tue, 11 Apr 2017 14:08:32 -0700
changeset 403283 d7c310377bdf86be5104a6cee0a99dac8cd6693b
parent 403282 c69eea74cf6f8245057fe541b41a3f0656922b73
child 403284 c44d096d361a7bb520569e0a5e005fc5e093dcea
push id1490
push usermtabara@mozilla.com
push dateMon, 31 Jul 2017 14:08:16 +0000
treeherdermozilla-release@70e32e6bf15e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbwc
bugs1355010
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1355010: temporarily turn off extmap direction verification to avoid Chrome interop issues. r=bwc MozReview-Commit-ID: 76Zayg9XMi7
media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
--- a/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
+++ b/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
@@ -2068,22 +2068,25 @@ JsepSessionImpl::ValidateAnswer(const Sd
       }
 
       for (const auto& ansExt : answerAttrs.GetExtmap().mExtmaps) {
         bool found = false;
         for (const auto& offExt : offerAttrs.GetExtmap().mExtmaps) {
           if (ansExt.extensionname == offExt.extensionname) {
             if ((ansExt.direction & reverse(offExt.direction))
                   != ansExt.direction) {
-              JSEP_SET_ERROR("Answer has inconsistent direction on extmap "
+              // FIXME we do not return an error here, because Chrome up to
+              // version 57 is actually tripping over this if they are the
+              // answerer. See bug 1355010 for details.
+              MOZ_MTLOG(ML_WARNING, "Answer has inconsistent direction on extmap "
                              "attribute at level " << i << " ("
                              << ansExt.extensionname << "). Offer had "
                              << offExt.direction << ", answer had "
                              << ansExt.direction << ".");
-              return NS_ERROR_INVALID_ARG;
+              // return NS_ERROR_INVALID_ARG;
             }
 
             if (offExt.entry < 4096 && (offExt.entry != ansExt.entry)) {
               JSEP_SET_ERROR("Answer changed id for extmap attribute at level "
                              << i << " (" << offExt.extensionname << ") from "
                              << offExt.entry << " to " << ansExt.entry << ".");
               return NS_ERROR_INVALID_ARG;
             }