Bug 1560704 - Revert the change `transform-style: inherit` added to ::-moz-table-wrapper in ua.css. r=birtles a=jcristau
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Wed, 26 Jun 2019 10:29:37 +0000
changeset 537114 d763b1f288a37f783de546ebeb4ce396a9a64cbd
parent 537113 abae727c471025c3a2d1006a401bdb4d70cd7bae
child 537115 268c9ae41d1f0b30d5f4cd875427f1d3386617de
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbirtles, jcristau
bugs1560704
milestone68.0
Bug 1560704 - Revert the change `transform-style: inherit` added to ::-moz-table-wrapper in ua.css. r=birtles a=jcristau It caused rendering issues just like a reftest in this commit. We don't know the reason but fixing it will be some amount of work which couldn't be uplifted to 68. So we just revert the change here now. Probably we should revisit the problem once we got a bug report that the lack of the `transform-style: inherit` causes rendering issues. Differential Revision: https://phabricator.services.mozilla.com/D35946
layout/reftests/transform-3d/preserve3d-table-ref.html
layout/reftests/transform-3d/preserve3d-table.html
layout/reftests/transform-3d/reftest.list
layout/style/res/ua.css
new file mode 100644
--- /dev/null
+++ b/layout/reftests/transform-3d/preserve3d-table-ref.html
@@ -0,0 +1,7 @@
+<!DOCTYPE html>
+<table>
+  <tbody>
+    <tr><td>RISK-184</td></tr>
+  </tbody>
+</table>
+
new file mode 100644
--- /dev/null
+++ b/layout/reftests/transform-3d/preserve3d-table.html
@@ -0,0 +1,7 @@
+<!DOCTYPE html>
+<table style="transform-style: preserve-3d">
+  <tbody style="transform: translate3d(0, 0, 0)">
+    <tr><td>RISK-184</td></tr>
+  </tbody>
+</table>
+
--- a/layout/reftests/transform-3d/reftest.list
+++ b/layout/reftests/transform-3d/reftest.list
@@ -17,16 +17,17 @@ fuzzy-if(gtkWidget||winWidget,0-8,0-376)
 == preserve3d-2a.html preserve3d-2-ref.html
 == preserve3d-2b.html preserve3d-2-ref.html
 == preserve3d-2c.html preserve3d-2-ref.html
 == preserve3d-2d.html preserve3d-2-ref.html
 == preserve3d-3a.html preserve3d-3-ref.html
 == preserve3d-4a.html about:blank
 fuzzy-if(gtkWidget,0-4,0-200) fuzzy-if(Android,0-4,0-300) fuzzy-if(winWidget&&!layersGPUAccelerated,0-2,0-100) fuzzy-if(skiaContent,0-16,0-100) == preserve3d-5a.html preserve3d-5-ref.html
 == preserve3d-6a.html preserve3d-6-ref.html
+== preserve3d-table.html preserve3d-table-ref.html
 == scale3d-z.html scalez-1-ref.html
 fuzzy-if(winWidget,0-143,0-689) fuzzy-if(OSX,0-224,0-924) fuzzy-if(winWidget,0-154,0-644) random-if(/^Windows\x20NT\x206\.1/.test(http.oscpu)) == scale3d-all.html scale3d-1-ref.html # subpixel AA
 fuzzy-if(winWidget,0-143,0-689) fuzzy-if(OSX,0-224,0-924) fuzzy-if(winWidget,0-154,0-644) random-if(/^Windows\x20NT\x206\.1/.test(http.oscpu)) == scale3d-all-separate.html scale3d-1-ref.html # subpixel AA
 == scale3d-xz.html scale3d-1-ref.html
 == translatez-1a.html translatez-1-ref.html
 != translatez-1b.html translatez-1-ref.html
 == translate3d-1a.html translate3d-1-ref.html
 fuzzy-if(skiaContent,0-1,0-4) == matrix3d-1a.html matrix3d-1-ref.html
--- a/layout/style/res/ua.css
+++ b/layout/style/res/ua.css
@@ -43,17 +43,17 @@
   line-height: inherit; /* needed for vertical-align on inline-table */
   /* Bug 722777 */
   transform: inherit;
   transform-origin: inherit;
   /* Bug 724750 */
   backface-visibility: inherit;
   clip: inherit;
   /* Other transform-related properties */
-  transform-style: inherit;
+  /* transform-style: inherit; Bug 1560704 */
   rotate: inherit;
   scale: inherit;
   translate: inherit;
   /* When the table wrapper is a Flex/Grid item we need these: */
   align-self: inherit;
   justify-self: inherit;
   grid-column-start: inherit;
   grid-column-end: inherit;