Bug 1384766 - Reduce expected frame count for GeckoProfiler.SuspendAndSample. r=njn, a=test-only
authorMichael Layzell <michael@thelayzells.com>
Mon, 14 Aug 2017 11:11:57 +1000
changeset 423542 d6f0fac3ee72018bd9049bc9c663225fde62d2fe
parent 423541 86c2d5d05229becc9914dca1b27a5771f8f94b42
child 423543 5fbb7413a6d4ec3aba41acf456d3efaeed02ce24
push id1517
push userjlorenzo@mozilla.com
push dateThu, 14 Sep 2017 16:50:54 +0000
treeherdermozilla-release@3b41fd564418 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn, test-only
bugs1384766
milestone56.0
Bug 1384766 - Reduce expected frame count for GeckoProfiler.SuspendAndSample. r=njn, a=test-only
tools/profiler/tests/gtest/GeckoProfiler.cpp
--- a/tools/profiler/tests/gtest/GeckoProfiler.cpp
+++ b/tools/profiler/tests/gtest/GeckoProfiler.cpp
@@ -765,17 +765,17 @@ void DoSuspendAndSample(int aTid, nsIThr
       "GeckoProfiler_SuspendAndSample_Test::TestBody",
       [&]() {
         uint32_t features = ProfilerFeature::Leaf;
         GTestStackCollector collector;
         profiler_suspend_and_sample_thread(aTid, features, collector,
                                            /* sampleNative = */ true);
 
         ASSERT_TRUE(collector.mSetIsMainThread == 1);
-        ASSERT_TRUE(collector.mFrames > 5); // approximate; must be > 0
+        ASSERT_TRUE(collector.mFrames > 0);
       }),
     NS_DISPATCH_SYNC);
 }
 
 TEST(GeckoProfiler, SuspendAndSample)
 {
   nsCOMPtr<nsIThread> thread;
   nsresult rv = NS_NewNamedThread("GeckoProfGTest", getter_AddRefs(thread));