Bug 1471004 - ignore partner_subset if it's an empty list. r=tomprince a=release
authorAki Sasaki <asasaki@mozilla.com>
Wed, 05 Jun 2019 15:04:12 -0700
changeset 542978 d691e2174680580b4651cc366ca776414c3fd67f
parent 542977 365cb98beddcfff93e2ce643fd8caac4be0d1529
child 543017 9b181decb95c108407e60a67222a7437cc20c8d8
push id2131
push userffxbld-merge
push dateMon, 26 Aug 2019 18:30:20 +0000
treeherdermozilla-release@b19ffb3ca153 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstomprince, release
bugs1471004
milestone69.0a1
first release with
nightly mac
d691e2174680 / 69.0a1 / 20190626160751 / files
nightly linux32
nightly linux64
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly mac
Bug 1471004 - ignore partner_subset if it's an empty list. r=tomprince a=release The relpro action requires a list for partner_subset and defaults to `[]`. In `get_partner_config_by_url` we check to see `if partner_subset`, ignoring the subset if it's an empty list. We either need to do the same thing in `get_partner_config_by_kind`, or we need to allow for a `null` value in the action (or populate an empty `partner_subset` with the partners from the partner config in the action) Differential Revision: https://phabricator.services.mozilla.com/D33861
taskcluster/taskgraph/util/partners.py
--- a/taskcluster/taskgraph/util/partners.py
+++ b/taskcluster/taskgraph/util/partners.py
@@ -322,17 +322,17 @@ def get_partner_config_by_kind(config, k
     # TODO eme-free should be a partner; we shouldn't care about per-kind
     for k in partner_configs:
         if kind.startswith(k):
             kind_config = partner_configs[k]
             break
     else:
         return {}
     # if we're only interested in a subset of partners we remove the rest
-    if isinstance(partner_subset, (list, tuple)):
+    if partner_subset:
         # TODO - should be fatal to have an unknown partner in partner_subset
         for partner in kind_config.keys():
             if partner not in partner_subset:
                 del(kind_config[partner])
 
     return kind_config