Bug 1522791 - Fix PropTypes warning in console; r=Honza.
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Fri, 25 Jan 2019 14:22:33 +0000
changeset 515457 d6552069b6d952b2e032422d5bd9f46b1b81edb1
parent 515456 0f54f0a8fc4a1813002ff0a29a342d793864d366
child 515458 f57d14800cbb5cf9f7c135d7e32ea5728fe7b377
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1522791
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1522791 - Fix PropTypes warning in console; r=Honza. This fixes PropTypes warning on MessageContainer and ConfirmDialog components. Differential Revision: https://phabricator.services.mozilla.com/D17636
devtools/client/webconsole/components/ConfirmDialog.js
devtools/client/webconsole/components/ConsoleOutput.js
--- a/devtools/client/webconsole/components/ConfirmDialog.js
+++ b/devtools/client/webconsole/components/ConfirmDialog.js
@@ -30,17 +30,17 @@ class ConfirmDialog extends Component {
   static get propTypes() {
     return {
       // Console object.
       hud: PropTypes.object.isRequired,
       // Update autocomplete popup state.
       autocompleteUpdate: PropTypes.func.isRequired,
       autocompleteClear: PropTypes.func.isRequired,
       // Data to be displayed in the confirm dialog.
-      getterPath: PropTypes.array.isRequired,
+      getterPath: PropTypes.array,
       serviceContainer: PropTypes.object.isRequired,
     };
   }
 
   constructor(props) {
     super(props);
 
     const { hud } = props;
--- a/devtools/client/webconsole/components/ConsoleOutput.js
+++ b/devtools/client/webconsole/components/ConsoleOutput.js
@@ -176,17 +176,17 @@ class ConsoleOutput extends Component {
       open: messagesUi.includes(messageId),
       tableData: messagesTableData.get(messageId),
       timestampsVisible,
       repeat: messagesRepeat[messageId],
       networkMessageUpdate: networkMessagesUpdate[messageId],
       networkMessageActiveTabId,
       pausedExecutionPoint,
       getMessage: () => messages.get(messageId),
-      isPaused: pausedMessage && pausedMessage.id == messageId,
+      isPaused: !!pausedMessage && pausedMessage.id == messageId,
       maybeScrollToBottom: this.maybeScrollToBottom,
     }));
 
     return (
       dom.div({
         className: "webconsole-output",
         onContextMenu: this.onContextMenu,
         ref: node => {