Bug 1546727: Remove extraneous 'inline' keywords, and add where missing. r=jorendorff
authorJim Blandy <jimb@mozilla.com>
Tue, 14 May 2019 02:55:56 +0000
changeset 535613 d57a8a8d3f8d2cec45ebb4fe4c832fffa0a6a8e0
parent 535612 f8b9b7dcd147413285007736cbb2ba51e79ca30d
child 535614 9c23e192d2f8ff9db68ddbf5a40dd3ec94bee054
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorendorff
bugs1546727
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1546727: Remove extraneous 'inline' keywords, and add where missing. r=jorendorff Differential Revision: https://phabricator.services.mozilla.com/D29113
js/src/vm/Debugger-inl.h
js/src/vm/Debugger.h
--- a/js/src/vm/Debugger-inl.h
+++ b/js/src/vm/Debugger-inl.h
@@ -51,67 +51,67 @@
 /* static */ inline bool js::Debugger::checkNoExecute(JSContext* cx,
                                                       HandleScript script) {
   if (!cx->realm()->isDebuggee() || !cx->noExecuteDebuggerTop) {
     return true;
   }
   return slowPathCheckNoExecute(cx, script);
 }
 
-/* static */ js::ResumeMode js::Debugger::onEnterFrame(JSContext* cx,
+/* static */ inline js::ResumeMode js::Debugger::onEnterFrame(JSContext* cx,
                                                        AbstractFramePtr frame) {
   MOZ_ASSERT_IF(frame.hasScript() && frame.script()->isDebuggee(),
                 frame.isDebuggee());
   if (!frame.isDebuggee()) {
     return ResumeMode::Continue;
   }
   return slowPathOnEnterFrame(cx, frame);
 }
 
-/* static */ js::ResumeMode js::Debugger::onResumeFrame(
+/* static */ inline js::ResumeMode js::Debugger::onResumeFrame(
     JSContext* cx, AbstractFramePtr frame) {
   MOZ_ASSERT_IF(frame.hasScript() && frame.script()->isDebuggee(),
                 frame.isDebuggee());
   if (!frame.isDebuggee()) {
     return ResumeMode::Continue;
   }
   return slowPathOnResumeFrame(cx, frame);
 }
 
-/* static */ js::ResumeMode js::Debugger::onDebuggerStatement(
+/* static */ inline js::ResumeMode js::Debugger::onDebuggerStatement(
     JSContext* cx, AbstractFramePtr frame) {
   if (!cx->realm()->isDebuggee()) {
     return ResumeMode::Continue;
   }
   return slowPathOnDebuggerStatement(cx, frame);
 }
 
-/* static */ js::ResumeMode js::Debugger::onExceptionUnwind(
+/* static */ inline js::ResumeMode js::Debugger::onExceptionUnwind(
     JSContext* cx, AbstractFramePtr frame) {
   if (!cx->realm()->isDebuggee()) {
     return ResumeMode::Continue;
   }
   return slowPathOnExceptionUnwind(cx, frame);
 }
 
-/* static */ void js::Debugger::onNewWasmInstance(
+/* static */ inline void js::Debugger::onNewWasmInstance(
     JSContext* cx, Handle<WasmInstanceObject*> wasmInstance) {
   if (cx->realm()->isDebuggee()) {
     slowPathOnNewWasmInstance(cx, wasmInstance);
   }
 }
 
-/* static */ void js::Debugger::onNewPromise(JSContext* cx,
+/* static */ inline void js::Debugger::onNewPromise(JSContext* cx,
                                              Handle<PromiseObject*> promise) {
   if (MOZ_UNLIKELY(cx->realm()->isDebuggee())) {
     slowPathPromiseHook(cx, Debugger::OnNewPromise, promise);
   }
 }
 
-/* static */ void js::Debugger::onPromiseSettled(
+/* static */ inline void js::Debugger::onPromiseSettled(
     JSContext* cx, Handle<PromiseObject*> promise) {
   if (MOZ_UNLIKELY(promise->realm()->isDebuggee())) {
     slowPathPromiseHook(cx, Debugger::OnPromiseSettled, promise);
   }
 }
 
 inline js::Debugger* js::DebuggerEnvironment::owner() const {
   JSObject* dbgobj = &getReservedSlot(OWNER_SLOT).toObject();
--- a/js/src/vm/Debugger.h
+++ b/js/src/vm/Debugger.h
@@ -1872,24 +1872,24 @@ class BreakpointSite {
   // List of all js::Breakpoints at this instruction.
   using BreakpointList =
       mozilla::DoublyLinkedList<js::Breakpoint, SiteLinkAccess<js::Breakpoint>>;
   BreakpointList breakpoints;
   size_t enabledCount; /* number of breakpoints in the list that are enabled */
 
  protected:
   virtual void recompile(FreeOp* fop) = 0;
-  inline bool isEnabled() const { return enabledCount > 0; }
+  bool isEnabled() const { return enabledCount > 0; }
 
  public:
   BreakpointSite(Type type);
   Breakpoint* firstBreakpoint() const;
   virtual ~BreakpointSite() {}
   bool hasBreakpoint(Breakpoint* bp);
-  inline Type type() const { return type_; }
+  Type type() const { return type_; }
 
   void inc(FreeOp* fop);
   void dec(FreeOp* fop);
   bool isEmpty() const;
   virtual void destroyIfEmpty(FreeOp* fop) = 0;
 
   inline JSBreakpointSite* asJS();
   inline WasmBreakpointSite* asWasm();